Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1166743002: crash: Compress crash report with gzip on Linux (Closed)

Created:
5 years, 6 months ago by hashimoto
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

crash: Compress crash report with gzip on Linux BUG=495563 TEST=Open chrome://crash to upload a crash report and confirm chrome://crashes contains a new crash report. Committed: https://crrev.com/9e4fec0f333f834c1d745d509d04037fd4d4dfe2 Cr-Commit-Position: refs/heads/master@{#333012}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address comments #

Patch Set 3 : Add "-f" to avoid getting caught by prompt #

Total comments: 2

Patch Set 4 : sizeof(kGzipExtension) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -11 lines) Patch
M components/crash/app/breakpad_linux.cc View 1 2 3 2 chunks +61 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
hashimoto
5 years, 6 months ago (2015-06-02 11:55:08 UTC) #2
Lei Zhang
https://codereview.chromium.org/1166743002/diff/1/components/crash/app/breakpad_linux.cc File components/crash/app/breakpad_linux.cc (right): https://codereview.chromium.org/1166743002/diff/1/components/crash/app/breakpad_linux.cc#newcode1116 components/crash/app/breakpad_linux.cc:1116: if (sys_waitpid(gzip_child, nullptr, 0) != gzip_child) { Don't we ...
5 years, 6 months ago (2015-06-03 00:54:54 UTC) #3
hashimoto
https://codereview.chromium.org/1166743002/diff/1/components/crash/app/breakpad_linux.cc File components/crash/app/breakpad_linux.cc (right): https://codereview.chromium.org/1166743002/diff/1/components/crash/app/breakpad_linux.cc#newcode1116 components/crash/app/breakpad_linux.cc:1116: if (sys_waitpid(gzip_child, nullptr, 0) != gzip_child) { On 2015/06/03 ...
5 years, 6 months ago (2015-06-03 08:04:42 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/1166743002/diff/1/components/crash/app/breakpad_linux.cc File components/crash/app/breakpad_linux.cc (right): https://codereview.chromium.org/1166743002/diff/1/components/crash/app/breakpad_linux.cc#newcode1124 components/crash/app/breakpad_linux.cc:1124: memcpy(gzip_file, dumpfile, strlen(dumpfile)); On 2015/06/03 08:04:41, hashimoto wrote: ...
5 years, 6 months ago (2015-06-05 03:03:26 UTC) #5
hashimoto
https://codereview.chromium.org/1166743002/diff/40001/components/crash/app/breakpad_linux.cc File components/crash/app/breakpad_linux.cc (right): https://codereview.chromium.org/1166743002/diff/40001/components/crash/app/breakpad_linux.cc#newcode1128 components/crash/app/breakpad_linux.cc:1128: my_strlen(dumpfile) + my_strlen(kGzipExtension) + 1; On 2015/06/05 03:03:26, Lei ...
5 years, 6 months ago (2015-06-05 04:16:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166743002/60001
5 years, 6 months ago (2015-06-05 04:16:47 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-05 06:05:17 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9e4fec0f333f834c1d745d509d04037fd4d4dfe2 Cr-Commit-Position: refs/heads/master@{#333012}
5 years, 6 months ago (2015-06-05 06:06:31 UTC) #11
Lei Zhang
Can you check and make sure this is working? I found that the OOM crash ...
5 years, 4 months ago (2015-08-25 04:28:55 UTC) #12
hashimoto
On 2015/08/25 04:28:55, Lei Zhang wrote: > Can you check and make sure this is ...
5 years, 4 months ago (2015-08-25 04:41:19 UTC) #13
hashimoto
On 2015/08/25 04:41:19, hashimoto wrote: > On 2015/08/25 04:28:55, Lei Zhang wrote: > > Can ...
5 years, 4 months ago (2015-08-25 05:04:13 UTC) #14
Lei Zhang
5 years, 3 months ago (2015-08-26 20:42:49 UTC) #15
Message was sent while issue was closed.
On 2015/08/25 05:04:13, hashimoto wrote:
> On 45.0.2454.46 (Official Build) beta (64-bit), repeatedly calling
> insertAdjacentText() as described in crbug.com/524254
> results in a renderer crash and it got uploaded to the server (crash id =
> 7db5652f07aad5b5).
> 
> Could let me know the exact steps you followed to cause the crash when
> bisecting?

Nothing special, just visit the webpage. Thanks for trying to reproduce the bug.
I'll look into this.

Powered by Google App Engine
This is Rietveld 408576698