Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4901)

Unified Diff: chrome/browser/plugins/plugin_infobar_delegates.h

Issue 11667015: For the Metro mode infobar, move various variables from the caller side to the (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_infobar_delegates.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_infobar_delegates.h
===================================================================
--- chrome/browser/plugins/plugin_infobar_delegates.h (revision 174623)
+++ chrome/browser/plugins/plugin_infobar_delegates.h (working copy)
@@ -185,13 +185,18 @@
#if defined(OS_WIN)
class PluginMetroModeInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
- // Shows an infobar asking the user to switch to desktop chrome if they
- // want to use the plugin.
+ // The infobar can be used for two purposes: to inform the user about a
+ // missing plugin or to note that a plugin only works in desktop mode. These
+ // purposes require different messages, buttons, etc.
+ enum Mode {
+ MISSING_PLUGIN,
+ DESKTOP_MODE_REQUIRED,
+ };
+
PluginMetroModeInfoBarDelegate(InfoBarService* infobar_service,
- const string16& plugin_name,
- const string16& ok_label,
- const GURL& learn_more_url,
- bool show_dont_ask_again_button);
+ Mode mode,
+ const string16& name);
+
private:
virtual ~PluginMetroModeInfoBarDelegate();
@@ -205,10 +210,8 @@
virtual string16 GetLinkText() const OVERRIDE;
virtual bool LinkClicked(WindowOpenDisposition disposition) OVERRIDE;
- const string16 message_;
- const string16 ok_label_;
- const GURL learn_more_url_;
- const bool show_dont_ask_again_button_;
+ const Mode mode_;
+ const string16 name_;
DISALLOW_COPY_AND_ASSIGN(PluginMetroModeInfoBarDelegate);
};
« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_infobar_delegates.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698