Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: vm/scopes.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/scopes.h ('k') | vm/stub_code_ia32.cc » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/scopes.cc
===================================================================
--- vm/scopes.cc (revision 16583)
+++ vm/scopes.cc (working copy)
@@ -259,7 +259,7 @@
desc.info.index = var->index();
vars->Add(desc);
} else if (var->name().Equals(
- Symbols::Name(Symbols::kSavedEntryContextVar))) {
+ Symbols::Name(Symbols::kSavedEntryContextVarId))) {
// This is the local variable in which the function saves the
// caller's chain of closure contexts (caller's CTX register).
VarDesc desc;
@@ -526,7 +526,7 @@
// Create a descriptor for 'this' variable.
context_scope.SetTokenIndexAt(0, func.token_pos());
- context_scope.SetNameAt(0, Symbols::ThisHandle());
+ context_scope.SetNameAt(0, Symbols::This());
context_scope.SetIsFinalAt(0, true);
context_scope.SetIsConstAt(0, false);
const AbstractType& type = AbstractType::Handle(func.ParameterTypeAt(0));
« no previous file with comments | « vm/scopes.h ('k') | vm/stub_code_ia32.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698