Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1433)

Unified Diff: vm/scanner.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/resolver_test.cc ('k') | vm/scopes.h » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/scanner.cc
===================================================================
--- vm/scanner.cc (revision 16583)
+++ vm/scanner.cc (working copy)
@@ -426,19 +426,16 @@
SkipLine();
return;
}
- const String& kLibrary = String::Handle(Symbols::Library());
- const String& kImport = String::Handle(Symbols::Import());
- const String& kSource = String::Handle(Symbols::Source());
const String& ident = String::Handle(ConsumeIdentChars(false));
- if (ident.Equals(kLibrary)) {
+ if (ident.Equals(Symbols::Library())) {
current_token_.kind = Token::kLEGACY_LIBRARY;
return;
}
- if (ident.Equals(kImport)) {
+ if (ident.Equals(Symbols::Import())) {
current_token_.kind = Token::kLEGACY_IMPORT;
return;
}
- if (ident.Equals(kSource)) {
+ if (ident.Equals(Symbols::Source())) {
current_token_.kind = Token::kLEGACY_SOURCE;
return;
}
« no previous file with comments | « vm/resolver_test.cc ('k') | vm/scopes.h » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698