Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: vm/resolver_test.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/parser.cc ('k') | vm/scanner.cc » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/resolver_test.cc
===================================================================
--- vm/resolver_test.cc (revision 16583)
+++ vm/resolver_test.cc (working copy)
@@ -99,13 +99,12 @@
// Now try to resolve and invoke the static function in this class.
{
const int kNumArguments = 2;
- const Array& kNoArgumentNames = Array::Handle();
const Function& function = Function::Handle(
Resolver::ResolveStatic(library,
class_name,
static_function_name,
kNumArguments,
- kNoArgumentNames,
+ Object::empty_array(),
kResolveType));
EXPECT(!function.IsNull());
const Array& args = Array::Handle(Array::New(kNumArguments));
@@ -121,13 +120,12 @@
// Now try to resolve a static function with invalid argument count.
{
const int kNumArguments = 1;
- const Array& kNoArgumentNames = Array::Handle();
const Function& bad_function = Function::Handle(
Resolver::ResolveStatic(library,
class_name,
static_function_name,
kNumArguments,
- kNoArgumentNames,
+ Object::empty_array(),
kResolveType));
EXPECT(bad_function.IsNull());
}
@@ -138,13 +136,12 @@
String::Handle(String::New("statCall"));
const String& super_class_name = String::Handle(String::New("Base"));
const int kNumArguments = 0;
- const Array& kNoArgumentNames = Array::Handle();
const Function& super_function = Function::Handle(
Resolver::ResolveStatic(library,
super_class_name,
super_static_function_name,
kNumArguments,
- kNoArgumentNames,
+ Object::empty_array(),
kResolveType));
EXPECT(!super_function.IsNull());
}
« no previous file with comments | « vm/parser.cc ('k') | vm/scanner.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698