Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: vm/object_test.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/object.cc ('k') | vm/parser.cc » ('j') | vm/symbols.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object_test.cc
===================================================================
--- vm/object_test.cc (revision 16583)
+++ vm/object_test.cc (working copy)
@@ -3125,13 +3125,12 @@
{
// Weak property and value in new. Key in VM isolate.
HANDLESCOPE(isolate);
- String& key = String::Handle();
- key ^= Symbols::Dot();
String& value = String::Handle();
value ^= OneByteString::New("value", Heap::kNew);
weak ^= WeakProperty::New(Heap::kNew);
- weak.set_key(key);
+ weak.set_key(Symbols::Dot());
weak.set_value(value);
+ String& key = String::Handle();
key ^= OneByteString::null();
value ^= OneByteString::null();
}
@@ -3143,13 +3142,12 @@
{
// Weak property and value in old. Key in VM isolate.
HANDLESCOPE(isolate);
- String& key = String::Handle();
- key ^= Symbols::Dot();
String& value = String::Handle();
value ^= OneByteString::New("value", Heap::kOld);
weak ^= WeakProperty::New(Heap::kOld);
- weak.set_key(key);
+ weak.set_key(Symbols::Dot());
weak.set_value(value);
+ String& key = String::Handle();
key ^= OneByteString::null();
value ^= OneByteString::null();
}
« no previous file with comments | « vm/object.cc ('k') | vm/parser.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698