Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: vm/flow_graph_optimizer.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: vm/flow_graph_optimizer.cc
===================================================================
--- vm/flow_graph_optimizer.cc (revision 16583)
+++ vm/flow_graph_optimizer.cc (working copy)
@@ -612,7 +612,7 @@
instantiator,
type_args,
value_type,
- String::ZoneHandle(Symbols::New("value")));
+ Symbols::Value());
InsertBefore(call, assert_value, NULL, Definition::kValue);
}
@@ -2520,12 +2520,11 @@
}
if (FLAG_trace_type_check_elimination) {
- const String& name = String::Handle(Symbols::New("boolean expression"));
FlowGraphPrinter::PrintTypeCheck(parsed_function(),
instr->token_pos(),
instr->value(),
Type::Handle(Type::BoolType()),
- name,
+ Symbols::BooleanExpression(),
instr->is_eliminated());
}
}
@@ -2554,12 +2553,11 @@
}
if (FLAG_trace_type_check_elimination) {
- const String& name = String::Handle(Symbols::New("InstanceOf"));
FlowGraphPrinter::PrintTypeCheck(parsed_function(),
instr->token_pos(),
instr->value(),
instr->type(),
- name,
+ Symbols::InstanceOf(),
/* eliminated = */ true);
}
}
« no previous file with comments | « vm/flow_graph_compiler_x64.cc ('k') | vm/intermediate_language.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698