Convert all symbols accessor to return read only handles so that it is not necessary to create a ne…

vm/resolver_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
 #include "vm/object.h"
@@ skipping 81 matching lines @@
   const String& library_name = String::Handle(String::New(test_library_name));
   const Library& library =
       Library::Handle(Library::LookupLibrary(library_name));
   const String& class_name = String::Handle(String::New(test_class_name));
   const String& static_function_name =
       String::Handle(String::New(test_static_function_name));
 
   // Now try to resolve and invoke the static function in this class.
   {
     const int kNumArguments = 2;
-    const Array& kNoArgumentNames = Array::Handle();
     const Function& function = Function::Handle(
         Resolver::ResolveStatic(library,
                                 class_name,
                                 static_function_name,
                                 kNumArguments,
-                                kNoArgumentNames,
+                                Object::empty_array(),
                                 kResolveType));
     EXPECT(!function.IsNull());
     const Array& args = Array::Handle(Array::New(kNumArguments));
     const String& arg0 = String::Handle(String::New("junk"));
     args.SetAt(0, arg0);
     const Smi& arg1 = Smi::Handle(Smi::New(kTestValue));
     args.SetAt(1, arg1);
     const Smi& retval = Smi::Handle(
         reinterpret_cast<RawSmi*>(DartEntry::InvokeStatic(function, args)));
     EXPECT_EQ(kTestValue, retval.Value());
   }
 
   // Now try to resolve a static function with invalid argument count.
   {
     const int kNumArguments = 1;
-    const Array& kNoArgumentNames = Array::Handle();
     const Function& bad_function = Function::Handle(
         Resolver::ResolveStatic(library,
                                 class_name,
                                 static_function_name,
                                 kNumArguments,
-                                kNoArgumentNames,
+                                Object::empty_array(),
                                 kResolveType));
     EXPECT(bad_function.IsNull());
   }
 
   // Hierarchy walking.
   {
     const String& super_static_function_name =
         String::Handle(String::New("statCall"));
     const String& super_class_name = String::Handle(String::New("Base"));
     const int kNumArguments = 0;
-    const Array& kNoArgumentNames = Array::Handle();
     const Function& super_function = Function::Handle(
         Resolver::ResolveStatic(library,
                                 super_class_name,
                                 super_static_function_name,
                                 kNumArguments,
-                                kNoArgumentNames,
+                                Object::empty_array(),
                                 kResolveType));
     EXPECT(!super_function.IsNull());
   }
 }
 
 
 TEST_CASE(DartDynamicResolve) {
   const char* test_library_name = "ResolverApp";
   const char* test_class_name = "A";
   const char* test_function_name = "foo";
@@ skipping 60 matching lines @@
                                  super_function_name,
                                  kNumPositionalArguments,
                                  kNumNamedArguments));
     EXPECT(!super_function.IsNull());
   }
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart