Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: vm/intrinsifier_ia32.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // The intrinsic code below is executed before a method has built its frame. 5 // The intrinsic code below is executed before a method has built its frame.
6 // The return address is on the stack and the arguments below it. 6 // The return address is on the stack and the arguments below it.
7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved. 7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
8 // Each intrinsification method returns true if the corresponding 8 // Each intrinsification method returns true if the corresponding
9 // Dart method was intrinsified. 9 // Dart method was intrinsified.
10 10
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 return false; 167 return false;
168 } 168 }
169 169
170 170
171 bool Intrinsifier::ImmutableArray_getIndexed(Assembler* assembler) { 171 bool Intrinsifier::ImmutableArray_getIndexed(Assembler* assembler) {
172 return Array_getIndexed(assembler); 172 return Array_getIndexed(assembler);
173 } 173 }
174 174
175 175
176 static intptr_t ComputeObjectArrayTypeArgumentsOffset() { 176 static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
177 const String& class_name = String::Handle(Symbols::New("_ObjectArray"));
178 const Library& core_lib = Library::Handle(Library::CoreLibrary()); 177 const Library& core_lib = Library::Handle(Library::CoreLibrary());
179 const Class& cls = 178 const Class& cls =
180 Class::Handle(core_lib.LookupClassAllowPrivate(class_name)); 179 Class::Handle(core_lib.LookupClassAllowPrivate(Symbols::ObjectArray()));
181 ASSERT(!cls.IsNull()); 180 ASSERT(!cls.IsNull());
182 ASSERT(cls.HasTypeArguments()); 181 ASSERT(cls.HasTypeArguments());
183 ASSERT(cls.NumTypeArguments() == 1); 182 ASSERT(cls.NumTypeArguments() == 1);
184 const intptr_t field_offset = cls.type_arguments_field_offset(); 183 const intptr_t field_offset = cls.type_arguments_field_offset();
185 ASSERT(field_offset != Class::kNoTypeArguments); 184 ASSERT(field_offset != Class::kNoTypeArguments);
186 return field_offset; 185 return field_offset;
187 } 186 }
188 187
189 188
190 // Intrinsify only for Smi value and index. Non-smi values need a store buffer 189 // Intrinsify only for Smi value and index. Non-smi values need a store buffer
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1733 __ Bind(&is_true); 1732 __ Bind(&is_true);
1734 __ LoadObject(EAX, bool_true); 1733 __ LoadObject(EAX, bool_true);
1735 __ ret(); 1734 __ ret();
1736 return true; 1735 return true;
1737 } 1736 }
1738 1737
1739 #undef __ 1738 #undef __
1740 } // namespace dart 1739 } // namespace dart
1741 1740
1742 #endif // defined TARGET_ARCH_IA32 1741 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « vm/intermediate_language_x64.cc ('k') | vm/megamorphic_cache_table.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698