Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: vm/debugger.cc

Issue 11667012: Convert all symbols accessor to return read only handles so that it is not necessary to create a ne… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/debugger.h" 5 #include "vm/debugger.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 8
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 imported = lib.ImportLibraryAt(i); 1280 imported = lib.ImportLibraryAt(i);
1281 ASSERT(!imported.IsNull()); 1281 ASSERT(!imported.IsNull());
1282 CollectLibraryFields(field_list, imported, prefix_name, false); 1282 CollectLibraryFields(field_list, imported, prefix_name, false);
1283 } 1283 }
1284 LibraryPrefix& prefix = LibraryPrefix::Handle(isolate_); 1284 LibraryPrefix& prefix = LibraryPrefix::Handle(isolate_);
1285 LibraryPrefixIterator it(lib); 1285 LibraryPrefixIterator it(lib);
1286 while (it.HasNext()) { 1286 while (it.HasNext()) {
1287 prefix = it.GetNext(); 1287 prefix = it.GetNext();
1288 prefix_name = prefix.name(); 1288 prefix_name = prefix.name();
1289 ASSERT(!prefix_name.IsNull()); 1289 ASSERT(!prefix_name.IsNull());
1290 prefix_name = String::Concat(prefix_name, 1290 prefix_name = String::Concat(prefix_name, Symbols::Dot());
1291 String::Handle(isolate_, Symbols::Dot()));
1292 for (int i = 0; i < prefix.num_imports(); i++) { 1291 for (int i = 0; i < prefix.num_imports(); i++) {
1293 imported = prefix.GetLibrary(i); 1292 imported = prefix.GetLibrary(i);
1294 CollectLibraryFields(field_list, imported, prefix_name, false); 1293 CollectLibraryFields(field_list, imported, prefix_name, false);
1295 } 1294 }
1296 } 1295 }
1297 return Array::MakeArray(field_list); 1296 return Array::MakeArray(field_list);
1298 } 1297 }
1299 1298
1300 1299
1301 void Debugger::VisitObjectPointers(ObjectPointerVisitor* visitor) { 1300 void Debugger::VisitObjectPointers(ObjectPointerVisitor* visitor) {
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
1641 } 1640 }
1642 1641
1643 1642
1644 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) { 1643 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
1645 ASSERT(bpt->next() == NULL); 1644 ASSERT(bpt->next() == NULL);
1646 bpt->set_next(code_breakpoints_); 1645 bpt->set_next(code_breakpoints_);
1647 code_breakpoints_ = bpt; 1646 code_breakpoints_ = bpt;
1648 } 1647 }
1649 1648
1650 } // namespace dart 1649 } // namespace dart
OLDNEW
« no previous file with comments | « vm/dart_entry.cc ('k') | vm/debugger_api_impl.cc » ('j') | vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698