Convert all symbols accessor to return read only handles so that it is not necessary to create a ne…

vm/dart_entry.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_entry.h"
 
 #include "vm/code_generator.h"
 #include "vm/compiler.h"
 #include "vm/object_store.h"
 #include "vm/resolver.h"
@@ skipping 113 matching lines @@
       const Code& code = Code::Handle(function.CurrentCode());
       ASSERT(!code.IsNull());
       return entrypoint(code.EntryPoint(),
                         arguments_descriptor,
                         arguments,
                         context);
     }
   }
   // There is no compatible 'call' method, so invoke noSuchMethod.
   return InvokeNoSuchMethod(instance,
-                            String::Handle(Symbols::Call()),
+                            Symbols::Call(),
                             arguments,
                             arguments_descriptor);
 }
 
 
 RawObject* DartEntry::InvokeNoSuchMethod(const Instance& receiver,
                                          const String& target_name,
                                          const Array& arguments,
                                          const Array& arguments_descriptor) {
   ASSERT(receiver.raw() == arguments.At(0));
   // Allocate an InvocationMirror object.
   const Library& core_lib = Library::Handle(Library::CoreLibrary());
-  const String& invocation_mirror_name =
-      String::Handle(Symbols::InvocationMirror());
-  Class& invocation_mirror_class =
-      Class::Handle(core_lib.LookupClassAllowPrivate(invocation_mirror_name));
+  Class& invocation_mirror_class = Class::Handle(
+      core_lib.LookupClassAllowPrivate(Symbols::InvocationMirror()));
   ASSERT(!invocation_mirror_class.IsNull());
-  const String& allocation_function_name =
-      String::Handle(Symbols::AllocateInvocationMirror());
   const Function& allocation_function = Function::Handle(
       Resolver::ResolveStaticByName(invocation_mirror_class,
-                                    allocation_function_name,
+                                    Symbols::AllocateInvocationMirror(),
                                     Resolver::kIsQualified));
   ASSERT(!allocation_function.IsNull());
   const int kNumAllocationArgs = 3;
   const Array& allocation_args = Array::Handle(Array::New(kNumAllocationArgs));
   allocation_args.SetAt(0, target_name);
   allocation_args.SetAt(1, arguments_descriptor);
   allocation_args.SetAt(2, arguments);
   const Object& invocation_mirror = Object::Handle(
       InvokeStatic(allocation_function, allocation_args));
 
   // Now use the invocation mirror object and invoke NoSuchMethod.
-  const String& function_name = String::Handle(Symbols::NoSuchMethod());
   const int kNumArguments = 2;
   const int kNumNamedArguments = 0;
   const Function& function = Function::Handle(
       Resolver::ResolveDynamic(receiver,
-                               function_name,
+                               Symbols::NoSuchMethod(),
                                kNumArguments,
                                kNumNamedArguments));
   ASSERT(!function.IsNull());
   const Array& args = Array::Handle(Array::New(kNumArguments));
   args.SetAt(0, receiver);
   args.SetAt(1, invocation_mirror);
   return InvokeDynamic(function, args);
 }
 
 
@@ skipping 125 matching lines @@
   constructor_arguments.SetAt(0, exception_object);
   constructor_arguments.SetAt(
       1, Smi::Handle(Smi::New(Function::kCtorPhaseAll)));
   Object& obj = Object::Handle();
   for (intptr_t i = 0; i < arguments.Length(); i++) {
     obj = arguments.At(i);
     constructor_arguments.SetAt((i + kNumExtraArgs), obj);
   }
 
   String& constructor_name = String::Handle(
-      String::Concat(class_name, Symbols::DotHandle()));
+      String::Concat(class_name, Symbols::Dot()));
   Function& constructor =
       Function::Handle(cls.LookupConstructor(constructor_name));
   ASSERT(!constructor.IsNull());
   const Object& retval =
     Object::Handle(DartEntry::InvokeStatic(constructor, constructor_arguments));
   ASSERT(retval.IsNull() || retval.IsError());
   if (retval.IsError()) {
     return retval.raw();
   }
   return exception_object.raw();
 }
 
 
 RawObject* DartLibraryCalls::ToString(const Instance& receiver) {
-  const String& function_name =
-      String::Handle(Symbols::New("toString"));
   const int kNumArguments = 1;  // Receiver.
   const int kNumNamedArguments = 0;  // None.
   const Function& function = Function::Handle(
       Resolver::ResolveDynamic(receiver,
-                               function_name,
+                               Symbols::toString(),
                                kNumArguments,
                                kNumNamedArguments));
   ASSERT(!function.IsNull());
   const Array& args = Array::Handle(Array::New(kNumArguments));
   args.SetAt(0, receiver);
   const Object& result = Object::Handle(DartEntry::InvokeDynamic(function,
                                                                  args));
   ASSERT(result.IsInstance() || result.IsError());
   return result.raw();
 }
 
 
 RawObject* DartLibraryCalls::Equals(const Instance& left,
                                     const Instance& right) {
   const int kNumArguments = 2;
   const int kNumNamedArguments = 0;
   const Function& function = Function::Handle(
       Resolver::ResolveDynamic(left,
-                               Symbols::EqualOperatorHandle(),
+                               Symbols::EqualOperator(),
                                kNumArguments,
                                kNumNamedArguments));
   ASSERT(!function.IsNull());
 
   const Array& args = Array::Handle(Array::New(kNumArguments));
   args.SetAt(0, left);
   args.SetAt(1, right);
   const Object& result = Object::Handle(DartEntry::InvokeDynamic(function,
                                                                  args));
   ASSERT(result.IsInstance() || result.IsError());
   return result.raw();
 }
 
 
 RawObject* DartLibraryCalls::LookupReceivePort(Dart_Port port_id) {
   Isolate* isolate = Isolate::Current();
   Function& function =
       Function::Handle(isolate,
                        isolate->object_store()->lookup_receive_port_function());
   const int kNumArguments = 1;
   if (function.IsNull()) {
     Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
     ASSERT(!isolate_lib.IsNull());
-    const String& public_class_name =
-        String::Handle(Symbols::New("_ReceivePortImpl"));
     const String& class_name =
-        String::Handle(isolate_lib.PrivateName(public_class_name));
-    const String& function_name =
-        String::Handle(Symbols::New("_lookupReceivePort"));
-    const Array& kNoArgumentNames = Array::Handle();
+        String::Handle(isolate_lib.PrivateName(Symbols::_ReceivePortImpl()));
     function = Resolver::ResolveStatic(isolate_lib,
                                        class_name,
-                                       function_name,
+                                       Symbols::_lookupReceivePort(),
                                        kNumArguments,
-                                       kNoArgumentNames,
+                                       Object::empty_array(),
                                        Resolver::kIsQualified);
     isolate->object_store()->set_lookup_receive_port_function(function);
   }
   const Array& args = Array::Handle(Array::New(kNumArguments));
   args.SetAt(0, Integer::Handle(Integer::New(port_id)));
   const Object& result =
       Object::Handle(DartEntry::InvokeStatic(function, args));
   return result.raw();
 }
 
 
 RawObject* DartLibraryCalls::HandleMessage(const Object& receive_port,
                                            Dart_Port reply_port_id,
                                            const Instance& message) {
   Isolate* isolate = Isolate::Current();
   Function& function =
       Function::Handle(isolate,
                        isolate->object_store()->handle_message_function());
   const int kNumArguments = 3;
   if (function.IsNull()) {
     Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
     ASSERT(!isolate_lib.IsNull());
-    const String& public_class_name =
-        String::Handle(Symbols::New("_ReceivePortImpl"));
     const String& class_name =
-        String::Handle(isolate_lib.PrivateName(public_class_name));
-    const String& function_name =
-        String::Handle(Symbols::New("_handleMessage"));
-    const Array& kNoArgumentNames = Array::Handle();
+        String::Handle(isolate_lib.PrivateName(Symbols::_ReceivePortImpl()));
     function = Resolver::ResolveStatic(isolate_lib,
                                        class_name,
-                                       function_name,
+                                       Symbols::_handleMessage(),
                                        kNumArguments,
-                                       kNoArgumentNames,
+                                       Object::empty_array(),
                                        Resolver::kIsQualified);
     isolate->object_store()->set_handle_message_function(function);
   }
   const Array& args = Array::Handle(isolate, Array::New(kNumArguments));
   args.SetAt(0, receive_port);
   args.SetAt(1, Integer::Handle(isolate, Integer::New(reply_port_id)));
   args.SetAt(2, message);
   const Object& result =
       Object::Handle(isolate, DartEntry::InvokeStatic(function, args));
   ASSERT(result.IsNull() || result.IsError());
   return result.raw();
 }
 
 
 RawObject* DartLibraryCalls::NewSendPort(intptr_t port_id) {
   Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
   ASSERT(!isolate_lib.IsNull());
-  const String& public_class_name =
-      String::Handle(String::New("_SendPortImpl"));
   const String& class_name =
-      String::Handle(isolate_lib.PrivateName(public_class_name));
-  const String& function_name = String::Handle(Symbols::New("_create"));
+      String::Handle(isolate_lib.PrivateName(Symbols::_SendPortImpl()));
   const int kNumArguments = 1;
-  const Array& kNoArgumentNames = Array::Handle();
   const Function& function = Function::Handle(
       Resolver::ResolveStatic(isolate_lib,
                               class_name,
-                              function_name,
+                              Symbols::_create(),
                               kNumArguments,
-                              kNoArgumentNames,
+                              Object::empty_array(),
                               Resolver::kIsQualified));
   const Array& args = Array::Handle(Array::New(kNumArguments));
   args.SetAt(0, Integer::Handle(Integer::New(port_id)));
   return DartEntry::InvokeStatic(function, args);
 }
 
 
 RawObject* DartLibraryCalls::MapSetAt(const Instance& map,
                                       const Instance& key,
                                       const Instance& value) {
-  String& name = String::Handle(Symbols::AssignIndexToken());
   const int kNumArguments = 3;
   const Function& function = Function::Handle(
-      Resolver::ResolveDynamic(map, name, kNumArguments, 0));
+      Resolver::ResolveDynamic(map,
+                               Symbols::AssignIndexToken(),
+                               kNumArguments,
+                               0));
   ASSERT(!function.IsNull());
   const Array& args = Array::Handle(Array::New(kNumArguments));
   args.SetAt(0, map);
   args.SetAt(1, key);
   args.SetAt(2, value);
   const Object& result = Object::Handle(DartEntry::InvokeDynamic(function,
                                                                  args));
   return result.raw();
 }
 
 
 RawObject* DartLibraryCalls::PortGetId(const Instance& port) {
-  const String& field_name = String::Handle(Symbols::New("_id"));
   const Class& cls = Class::Handle(port.clazz());
-  const String& func_name = String::Handle(Field::GetterName(field_name));
+  const String& func_name = String::Handle(Field::GetterName(Symbols::_id()));
   const Function& func = Function::Handle(cls.LookupDynamicFunction(func_name));
   ASSERT(!func.IsNull());
   const Array& args = Array::Handle(Array::New(1));
   args.SetAt(0, port);
   return DartEntry::InvokeDynamic(func, args);
 }
 
 
 }  // namespace dart