Convert all symbols accessor to return read only handles so that it is not necessary to create a ne…

vm/ast.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_AST_H_
 #define VM_AST_H_
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
@@ skipping 356 matching lines @@
  public:
   AssignableNode(intptr_t token_pos,
                  AstNode* expr,
                  const AbstractType& type,
                  const String& dst_name)
       : AstNode(token_pos), expr_(expr), type_(type), dst_name_(dst_name) {
     ASSERT(expr_ != NULL);
     ASSERT(type_.IsZoneHandle());
     ASSERT(!type_.IsNull());
     ASSERT(type_.IsFinalized());
-    ASSERT(dst_name_.IsZoneHandle());
+    ASSERT(dst_name_.IsNotTemporaryScopedHandle());
   }
 
   AstNode* expr() const { return expr_; }
   const AbstractType& type() const { return type_; }
   const String& dst_name() const { return dst_name_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     expr()->Visit(visitor);
   }
 
@@ skipping 53 matching lines @@
 
 
 // Primary nodes hold identifiers or values (library, class or function)
 // resolved from an identifier. Primary nodes should not ever make it to the
 // code generation phase as they will be transformed into the correct call or
 // field access nodes.
 class PrimaryNode : public AstNode {
  public:
   PrimaryNode(intptr_t token_pos, const Object& primary)
       : AstNode(token_pos), primary_(primary) {
-    ASSERT(primary_.IsZoneHandle());
+    ASSERT(primary_.IsNotTemporaryScopedHandle());
   }
 
   const Object& primary() const { return primary_; }
 
   bool IsSuper() const {
-    return primary().IsString() && (primary().raw() == Symbols::Super());
+    return primary().IsString() && (primary().raw() == Symbols::Super().raw());
   }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const;
 
   DECLARE_COMMON_NODE_FUNCTIONS(PrimaryNode);
 
  private:
   const Object& primary_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(PrimaryNode);
@@ skipping 726 matching lines @@
  public:
   InstanceCallNode(intptr_t token_pos,
                    AstNode* receiver,
                    const String& function_name,
                    ArgumentListNode* arguments)
       : AstNode(token_pos),
         receiver_(receiver),
         function_name_(function_name),
         arguments_(arguments) {
     ASSERT(receiver_ != NULL);
-    ASSERT(function_name_.IsZoneHandle());
+    ASSERT(function_name_.IsNotTemporaryScopedHandle());
     ASSERT(function_name_.IsSymbol());
     ASSERT(arguments_ != NULL);
   }
 
   AstNode* receiver() const { return receiver_; }
   const String& function_name() const { return function_name_; }
   ArgumentListNode* arguments() const { return arguments_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     receiver()->Visit(visitor);
@@ skipping 13 matching lines @@
 
 class InstanceGetterNode : public AstNode {
  public:
   InstanceGetterNode(intptr_t token_pos,
                      AstNode* receiver,
                      const String& field_name)
       : AstNode(token_pos),
         receiver_(receiver),
         field_name_(field_name) {
     ASSERT(receiver_ != NULL);
-    ASSERT(field_name_.IsZoneHandle());
+    ASSERT(field_name_.IsNotTemporaryScopedHandle());
     ASSERT(field_name_.IsSymbol());
   }
 
   AstNode* receiver() const { return receiver_; }
   const String& field_name() const { return field_name_; }
 
   virtual void VisitChildren(AstNodeVisitor* visitor) const {
     receiver()->Visit(visitor);
   }
 
@@ skipping 450 matching lines @@
   const LocalVariable& context_var_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode);
 };
 
 }  // namespace dart
 
 #undef DECLARE_COMMON_NODE_FUNCTIONS
 
 #endif  // VM_AST_H_