Convert all symbols accessor to return read only handles so that it is not necessary to create a ne…

lib/isolate.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/bootstrap_natives.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
@@ skipping 42 matching lines @@
 // TODO(turnidge): Move to DartLibraryCalls.
 static RawObject* ReceivePortCreate(intptr_t port_id) {
   Isolate* isolate = Isolate::Current();
   Function& func =
       Function::Handle(isolate,
                        isolate->object_store()->receive_port_create_function());
   const int kNumArguments = 1;
   if (func.IsNull()) {
     Library& isolate_lib = Library::Handle(Library::IsolateLibrary());
     ASSERT(!isolate_lib.IsNull());
-    const String& public_class_name =
-        String::Handle(Symbols::New("_ReceivePortImpl"));
     const String& class_name =
-        String::Handle(isolate_lib.PrivateName(public_class_name));
-    const String& function_name =
-        String::Handle(Symbols::New("_get_or_create"));
-    const Array& kNoArgumentNames = Array::Handle();
+        String::Handle(isolate_lib.PrivateName(Symbols::_ReceivePortImpl()));
     func = Resolver::ResolveStatic(isolate_lib,
                                    class_name,
-                                   function_name,
+                                   Symbols::_get_or_create(),
                                    kNumArguments,
-                                   kNoArgumentNames,
+                                   Object::empty_array(),
                                    Resolver::kIsQualified);
     isolate->object_store()->set_receive_port_create_function(func);
   }
   const Array& args = Array::Handle(isolate, Array::New(kNumArguments));
   args.SetAt(0, Integer::Handle(isolate, Integer::New(port_id)));
   const Object& result =
       Object::Handle(isolate, DartEntry::InvokeStatic(func, args));
   if (!result.IsError()) {
     PortMap::SetLive(port_id);
   }
@@ skipping 408 matching lines @@
 
 DEFINE_NATIVE_ENTRY(isolate_getPortInternal, 0) {
   const Object& port = Object::Handle(ReceivePortCreate(isolate->main_port()));
   if (port.IsError()) {
     Exceptions::PropagateError(Error::Cast(port));
   }
   return port.raw();
 }
 
 }  // namespace dart