Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1166693004: Use SequencedSocketData in HttpStreamParserTests. (Closed)

Created:
5 years, 6 months ago by mmenke
Modified:
5 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SequencedSocketData in HttpStreamParserTests. SequencedSocketData is a bit cleaner and easier to use than the alternatives, which we may want to get rid of, long term. HttpStreamParser.AsyncChunkAndAsyncSocketWithMultipleChunks did rely on DeterministicSocketData's behavior to get in a state where the previous chunked upload body write was pending when data was appended to the chunked upload data stream, but the updated test uses a new method to ensure that happens. BUG=492696 Committed: https://crrev.com/f22be0eee8f8fd21aba8c305da14b61bf137023d Cr-Commit-Position: refs/heads/master@{#333054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -164 lines) Patch
M net/http/http_stream_parser_unittest.cc View 25 chunks +51 lines, -164 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
Ryan: Mind reviewing? There isn't really anyone obvious to send this to. The only test ...
5 years, 6 months ago (2015-06-04 20:02:37 UTC) #2
Ryan Hamilton
lgtm SWEEEEEEEEEEEEET!
5 years, 6 months ago (2015-06-04 22:58:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166693004/1
5 years, 6 months ago (2015-06-05 15:08:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 15:39:08 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 15:40:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f22be0eee8f8fd21aba8c305da14b61bf137023d
Cr-Commit-Position: refs/heads/master@{#333054}

Powered by Google App Engine
This is Rietveld 408576698