Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: lib/src/options.dart

Issue 1166683005: upgrade dependencies, including migration to package:test (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/dart_codegen.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 0b4778c2e19fcc4bac42f817b92fcbe47d792451..4abc5a0c822c03faa96002ba79accabdcec9ab99 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -124,13 +124,11 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
/// Whether to force compilation of code with static errors.
final bool forceCompile;
- /// Whether to run the dart_style formatter on the generated Dart code.
+ /// Whether to use a cheap formatter instead of dart_style.
+ // TODO(jmesserly): old comment said this might not be a semantically correct
+ // formatter. Why not?
final bool formatOutput;
- /// Whether to use a cheap formatter instead of dart_style. This might not be
- /// a semantically correct formatter and it is used for testing only.
- final bool cheapTestFormat;
-
/// Output directory for generated code.
final String outputDir;
@@ -241,7 +239,7 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
CompilerOptions({this.allowConstCasts: true, this.checkSdk: false,
this.dumpInfo: false, this.dumpInfoFile, this.dumpSrcDir,
this.forceCompile: false, this.formatOutput: false,
- this.cheapTestFormat: false, this.ignoreTypes: false,
+ this.ignoreTypes: false,
this.wrapClosures: RulesOptions.wrapClosuresDefault, this.outputDir,
this.outputDart: false, this.useColors: true,
this.covariantGenerics: true, this.relaxedCasts: true,
« no previous file with comments | « lib/src/codegen/dart_codegen.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698