Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1166683005: upgrade dependencies, including migration to package:test (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly
Modified:
5 years, 6 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

upgrade dependencies, including migration to package:test dart_style becomes a dev_dependency, and remove the ability to auto-run it from dart backend, instead use the test formatter migrate to package:test, which has a few tricky bits: * expect can only appear inside a test now (https://github.com/dart-lang/test/issues/132) * mirrors is needed to get the test folder (https://github.com/dart-lang/test/issues/110) * test `main` can't take arguments. not sure what's up there, but not a big deal for us either. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/04e9e762c1f44dda074ce211335d81892c8852e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -159 lines) Patch
M lib/src/codegen/dart_codegen.dart View 3 chunks +1 line, -11 lines 0 comments Download
M lib/src/options.dart View 2 chunks +4 lines, -6 lines 0 comments Download
M lib/src/testing.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 2 chunks +7 lines, -7 lines 0 comments Download
M test/all_tests.dart View 2 chunks +4 lines, -10 lines 0 comments Download
M test/checker/checker_test.dart View 1 chunk +1 line, -5 lines 0 comments Download
M test/checker/inferred_type_test.dart View 2 chunks +30 lines, -31 lines 0 comments Download
M test/checker/self_host_test.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M test/codegen_test.dart View 7 chunks +7 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/a/a.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M test/dart_codegen/expect/b/b.dart View 1 chunk +4 lines, -6 lines 0 comments Download
M test/dart_codegen/expect/c/c.dart View 1 chunk +6 lines, -12 lines 0 comments Download
M test/dart_codegen/expect/d/d.dart View 1 chunk +6 lines, -12 lines 0 comments Download
M test/dart_codegen/expect/types/types.dart View 1 chunk +1 line, -2 lines 0 comments Download
M test/dependency_graph_test.dart View 2 chunks +1 line, -5 lines 0 comments Download
M test/end_to_end_test.dart View 1 chunk +4 lines, -7 lines 0 comments Download
M test/report_test.dart View 1 chunk +1 line, -5 lines 0 comments Download
M test/runtime/dart_logging_runtime_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/runtime/dart_runtime_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/test_util.dart View 1 chunk +5 lines, -9 lines 0 comments Download
M tool/test.sh View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jennifer Messerly
I'll push a branch too so we can get travis results
5 years, 6 months ago (2015-06-01 21:10:56 UTC) #2
Jennifer Messerly
On 2015/06/01 21:10:56, John Messerly wrote: > I'll push a branch too so we can ...
5 years, 6 months ago (2015-06-01 21:11:22 UTC) #3
Jennifer Messerly
Passed https://travis-ci.org/dart-lang/dev_compiler/builds/64984494
5 years, 6 months ago (2015-06-01 21:19:06 UTC) #4
vsm
lgtm!
5 years, 6 months ago (2015-06-01 21:50:10 UTC) #5
Jennifer Messerly
5 years, 6 months ago (2015-06-01 21:54:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04e9e762c1f44dda074ce211335d81892c8852e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698