Issue 1166653005: Don't create layout objects for pre-wrap text nodes in SVG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166653005: Don't create layout objects for pre-wrap text nodes in SVG (Closed)

Created:
5 years, 6 months ago by fs

Modified:
5 years, 6 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Don't create layout objects for pre-wrap text nodes in SVG SVGTextMetricsBuilder only knows how to handle 'white-space: pre' with regards to whitespace preservation, meaning it will collapse the spaces in the node, and hence not generate any SVGTextMetrics for it. Filter this case out to avoid even creating the text layout object in the first place. Fix salvaged from https://codereview.chromium.org/755613002/, with prior work by Peter Molnar (pmolnar.u-szeged@partner.samsung.com) and Zoltan Herczeg (zherczeg.u-szeged@partner.samsung.com). Test simplified and extended to cover all white-space values. BUG=416833, 495969 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196558

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -1 line)			Patch
A	LayoutTests/svg/text/white-space-pre-wrap-whitespace-only-crash.html	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/text/white-space-pre-wrap-whitespace-only-crash-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/dom/Text.cpp	View	1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166653005/1

5 years, 6 months ago (2015-06-05 06:31:28 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-05 06:34:49 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196558