Implement %TypedArray%.prototype.{toString,toLocaleString,join}

src/harmony-typedarray.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
@@ skipping 22 matching lines @@
 
 var ArrayFrom;
 var InnerArrayCopyWithin;
 var InnerArrayEvery;
 var InnerArrayFill;
 var InnerArrayFilter;
 var InnerArrayFind;
 var InnerArrayFindIndex;
 var InnerArrayForEach;
 var InnerArrayIndexOf;
+var InnerArrayJoin;
 var InnerArrayLastIndexOf;
 var InnerArrayMap;
 var InnerArrayReverse;
 var InnerArraySome;
 var InnerArraySort;
+var InnerArrayToLocaleString;
 var IsNaN;
+var ObjectToString;
 
 utils.Import(function(from) {
   ArrayFrom = from.ArrayFrom;
   InnerArrayCopyWithin = from.InnerArrayCopyWithin;
   InnerArrayEvery = from.InnerArrayEvery;
   InnerArrayFill = from.InnerArrayFill;
   InnerArrayFilter = from.InnerArrayFilter;
   InnerArrayFind = from.InnerArrayFind;
   InnerArrayFindIndex = from.InnerArrayFindIndex;
   InnerArrayForEach = from.InnerArrayForEach;
   InnerArrayIndexOf = from.InnerArrayIndexOf;
+  InnerArrayJoin = from.InnerArrayJoin;
   InnerArrayLastIndexOf = from.InnerArrayLastIndexOf;
   InnerArrayMap = from.InnerArrayMap;
   InnerArrayReverse = from.InnerArrayReverse;
   InnerArraySome = from.InnerArraySome;
   InnerArraySort = from.InnerArraySort;
+  InnerArrayToLocaleString = from.InnerArrayToLocaleString;
   IsNaN = from.IsNaN;
+  ObjectToString = from.ObjectToString;
 });
 
 // -------------------------------------------------------------------
 
 function ConstructTypedArray(constructor, array) {
   // TODO(littledan): This is an approximation of the spec, which requires
   // that only real TypedArray classes should be accepted (22.2.2.1.1)
   if (!%IsConstructor(constructor) || IS_UNDEFINED(constructor.prototype) ||
       !%HasOwnProperty(constructor.prototype, "BYTES_PER_ELEMENT")) {
     throw MakeTypeError(kNotTypedArray);
@@ skipping 167 matching lines @@
 function TypedArraySome(f, receiver) {
   if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
 
   var length = %_TypedArrayGetLength(this);
 
   return InnerArraySome(f, receiver, this, length);
 }
 %FunctionSetLength(TypedArraySome, 1);
 
 
+// ES6 section 22.2.3.27
+function TypedArrayToLocaleString() {
+  if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
+
+  var length = %_TypedArrayGetLength(this);
+
+  return InnerArrayToLocaleString(this, length);
+}
+
+
+// ES6 section 22.2.3.28
+function TypedArrayToString() {

[adamk, 2015/06/02 17:18:20]

According to the spec this function doesn't exist: just install ArrayToString on
%TypedArray%.prototype (and add a test for that).

+  if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
+
+  var func = this.join;
+  if (!IS_SPEC_FUNCTION(func)) {
+    return %_CallFunction(this, ObjectToString);
+  }
+  return %_CallFunction(this, func);
+}
+
+
+// ES6 section 22.2.3.14
+function TypedArrayJoin(separator) {
+  if (!%IsTypedArray(this)) throw MakeTypeError(kNotTypedArray);
+
+  var length = %_TypedArrayGetLength(this);
+
+  return InnerArrayJoin(separator, this, length);
+}
+
+
 // ES6 draft 08-24-14, section 22.2.2.2
 function TypedArrayOf() {
   var length = %_ArgumentsLength();
   var array = new this(length);
   for (var i = 0; i < length; i++) {
     array[i] = %_Arguments(i);
   }
   return array;
 }
 
@@ skipping 16 matching lines @@
 
   // Set up non-enumerable functions on the prototype object.
   utils.InstallFunctions(GlobalNAME.prototype, DONT_ENUM, [
     "copyWithin", TypedArrayCopyWithin,
     "every", TypedArrayEvery,
     "fill", TypedArrayFill,
     "filter", TypedArrayFilter,
     "find", TypedArrayFind,
     "findIndex", TypedArrayFindIndex,
     "indexOf", TypedArrayIndexOf,
+    "join", TypedArrayJoin,
     "lastIndexOf", TypedArrayLastIndexOf,
     "forEach", TypedArrayForEach,
     "map", TypedArrayMap,
     "reverse", TypedArrayReverse,
     "some", TypedArraySome,
-    "sort", TypedArraySort
+    "sort", TypedArraySort,
+    "toString", TypedArrayToString,
+    "toLocaleString", TypedArrayToLocaleString
   ]);
 endmacro
 
 TYPED_ARRAYS(EXTEND_TYPED_ARRAY)
 
 })