Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1166623004: Implement %TypedArray%.prototype.{toString,toLocaleString,join} (Closed)

Created:
5 years, 6 months ago by dehrenberg
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implement %TypedArray%.prototype.{toString,toLocaleString,join} Implementations factored out from Array. Tests are derived from normal array toString tests. BUG=v8:3578 LOG=Y R=adamk Committed: https://crrev.com/4f9df26b09b997d40910eeaad1e6d627f11f591d Cr-Commit-Position: refs/heads/master@{#28766}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix toString #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -9 lines) Patch
M src/array.js View 1 3 chunks +22 lines, -8 lines 0 comments Download
M src/harmony-typedarray.js View 1 5 chunks +34 lines, -1 line 0 comments Download
M src/prologue.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typedarray-tostring.js View 1 1 chunk +88 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dehrenberg
5 years, 6 months ago (2015-06-02 02:33:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166623004/1
5 years, 6 months ago (2015-06-02 17:11:04 UTC) #3
commit-bot: I haz the power
Dry run: No LGTM from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 6 months ago (2015-06-02 17:11:06 UTC) #5
adamk
https://codereview.chromium.org/1166623004/diff/1/src/harmony-typedarray.js File src/harmony-typedarray.js (right): https://codereview.chromium.org/1166623004/diff/1/src/harmony-typedarray.js#newcode270 src/harmony-typedarray.js:270: function TypedArrayToString() { According to the spec this function ...
5 years, 6 months ago (2015-06-02 17:18:20 UTC) #6
dehrenberg
On 2015/06/02 at 17:18:20, adamk wrote: > https://codereview.chromium.org/1166623004/diff/1/src/harmony-typedarray.js > File src/harmony-typedarray.js (right): > > https://codereview.chromium.org/1166623004/diff/1/src/harmony-typedarray.js#newcode270 ...
5 years, 6 months ago (2015-06-02 18:21:09 UTC) #7
adamk
lgtm
5 years, 6 months ago (2015-06-02 18:23:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166623004/20001
5 years, 6 months ago (2015-06-02 18:24:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 18:58:16 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 18:58:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f9df26b09b997d40910eeaad1e6d627f11f591d
Cr-Commit-Position: refs/heads/master@{#28766}

Powered by Google App Engine
This is Rietveld 408576698