Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1166613003: cc: Change Layer::PushProps conditional to say what it means (Closed)

Created:
5 years, 6 months ago by enne (OOO)
Modified:
5 years, 6 months ago
Reviewers:
Ian Vollick
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Change Layer::PushProps conditional to say what it means This conditional really only applies when property trees are being used, even though currently impl-side painting and property trees are synonymous. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a570aa307530d83f610b6c5bd91e3117347ed15f Cr-Commit-Position: refs/heads/master@{#332962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/layer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
enne (OOO)
5 years, 6 months ago (2015-06-04 21:31:27 UTC) #2
Ian Vollick
lgtm
5 years, 6 months ago (2015-06-04 21:35:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166613003/1
5 years, 6 months ago (2015-06-04 21:43:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/94887)
5 years, 6 months ago (2015-06-04 22:05:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166613003/1
5 years, 6 months ago (2015-06-04 22:10:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 23:41:37 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 23:42:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a570aa307530d83f610b6c5bd91e3117347ed15f
Cr-Commit-Position: refs/heads/master@{#332962}

Powered by Google App Engine
This is Rietveld 408576698