Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1166603002: Move PermissionRequestID to chrome/browser/permissions/. (Closed)

Created:
5 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 6 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, johnme+watch_chromium.org, markusheintz_, mcasas+watch_chromium.org, mvanouwerkerk+watch_chromium.org, Michael van Ouwerkerk, peter+watch_chromium.org, posciak+watch_chromium.org, toyoshim+midi_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@permission_rfh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PermissionRequestID to chrome/browser/permissions/. BUG=479227 Committed: https://crrev.com/dfbf569c4c37aa656c9320abf837e4f0649661a5 Cr-Commit-Position: refs/heads/master@{#333219}

Patch Set 1 #

Patch Set 2 : fix gn build #

Patch Set 3 : build fixes #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -132 lines) Patch
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/content_settings/permission_bubble_request_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_context_base_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_infobar_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/permission_queue_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/permission_queue_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/midi_permission_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/protected_media_identifier_permission_context.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/permissions/permission_request_id.h View 1 chunk +48 lines, -0 lines 0 comments Download
A + chrome/browser/permissions/permission_request_id.cc View 1 chunk +11 lines, -7 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M components/content_settings.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/content_settings/core/common/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D components/content_settings/core/common/permission_request_id.h View 1 chunk +0 lines, -41 lines 0 comments Download
D components/content_settings/core/common/permission_request_id.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
mlamouri (slow - plz ping)
5 years, 6 months ago (2015-05-30 14:39:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-01 13:03:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166603002/1
5 years, 6 months ago (2015-06-04 10:08:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/78554)
5 years, 6 months ago (2015-06-04 10:17:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166603002/20001
5 years, 6 months ago (2015-06-04 10:24:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/77932)
5 years, 6 months ago (2015-06-04 10:34:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166603002/40001
5 years, 6 months ago (2015-06-04 17:48:25 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/44216)
5 years, 6 months ago (2015-06-04 18:19:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166603002/60001
5 years, 6 months ago (2015-06-06 18:01:26 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-06 18:53:52 UTC) #21
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 18:54:51 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/dfbf569c4c37aa656c9320abf837e4f0649661a5
Cr-Commit-Position: refs/heads/master@{#333219}

Powered by Google App Engine
This is Rietveld 408576698