Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1166563002: Remove support for variant info in chrome://settings/autofill (Closed)

Created:
5 years, 6 months ago by Evan Stade
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for variant info in chrome://settings/autofill BUG=493856 Committed: https://crrev.com/6a3d548a1b9ac31c1bb1d1127f25220f9f6d765a Cr-Commit-Position: refs/heads/master@{#332275}

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1064 lines) Patch
M chrome/browser/resources/options/autofill_edit_address_overlay.html View 1 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_address_overlay.js View 12 chunks +5 lines, -110 lines 1 comment Download
M chrome/browser/resources/options/autofill_options_list.js View 2 chunks +0 lines, -341 lines 0 comments Download
M chrome/browser/resources/options/options_bundle.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_browsertest.js View 1 5 chunks +8 lines, -65 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 9 chunks +14 lines, -147 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler_unittest.cc View 1 1 chunk +3 lines, -13 lines 0 comments Download
D chrome/browser/ui/webui/options/autofill_options_interactive_uitest.cc View 1 1 chunk +0 lines, -380 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Evan Stade
5 years, 6 months ago (2015-06-01 19:24:42 UTC) #2
please use gerrit instead
lgtm % one comment below. https://codereview.chromium.org/1166563002/diff/20001/chrome/browser/resources/options/autofill_edit_address_overlay.js File chrome/browser/resources/options/autofill_edit_address_overlay.js (left): https://codereview.chromium.org/1166563002/diff/20001/chrome/browser/resources/options/autofill_edit_address_overlay.js#oldcode323 chrome/browser/resources/options/autofill_edit_address_overlay.js:323: // Add the countries ...
5 years, 6 months ago (2015-06-01 21:20:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166563002/20001
5 years, 6 months ago (2015-06-01 23:37:28 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-02 00:47:49 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 00:49:27 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6a3d548a1b9ac31c1bb1d1127f25220f9f6d765a
Cr-Commit-Position: refs/heads/master@{#332275}

Powered by Google App Engine
This is Rietveld 408576698