Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(40)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1166553004: IndexedDB: Replace 0 with nullptr where appropriate (Closed)

Created:
4 years, 11 months ago by jsbell
Modified:
4 years, 11 months ago
Reviewers:
cmumford
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IndexedDB: Replace 0 with nullptr where appropriate R=cmumford@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196260

Patch Set 1 #

Patch Set 2 : MOAR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -158 lines) Patch
M Source/modules/indexeddb/DOMWindowIndexedDatabase.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 3 chunks +14 lines, -14 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M Source/modules/indexeddb/IDBFactory.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/modules/indexeddb/IDBIndex.cpp View 5 chunks +29 lines, -29 lines 0 comments Download
M Source/modules/indexeddb/IDBKeyRange.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBObjectStore.cpp View 16 chunks +65 lines, -65 lines 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 12 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jsbell
cmumford@ - please take a look?
4 years, 11 months ago (2015-05-29 17:59:53 UTC) #1
cmumford
lgtm
4 years, 11 months ago (2015-06-01 17:36:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166553004/20001
4 years, 11 months ago (2015-06-01 17:37:41 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64620)
4 years, 11 months ago (2015-06-01 20:29:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166553004/20001
4 years, 11 months ago (2015-06-01 20:35:42 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 00:27:50 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196260

Powered by Google App Engine
This is Rietveld 408576698