Issue 116653003: Fix CRAS unittests compile break after r238637.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 116653003: Fix CRAS unittests compile break after r238637. (Closed)

Created:
7 years ago by Pawel Osciak

Modified:
7 years ago

Reviewers:
dgreid, DaleCurtis

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix CRAS unittests compile break after r238637. Update CRAS unittests to pass the new audio log factory argument introduced to AudioManager's constructor to make media_unittests compile again. BUG=None TEST=Build media_unittests for CrOS, run CRAS tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242067

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	media/audio/cras/cras_input_unittest.cc	View		3 chunks	+6 lines, -0 lines	0 comments	Download
	M	media/audio/cras/cras_unified_unittest.cc	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/116653003/1

7 years ago (2013-12-19 22:17:23 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=108310

7 years ago (2013-12-20 07:27:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/posciak@chromium.org/116653003/1

7 years ago (2013-12-20 07:29:50 UTC) #6

Message was sent while issue was closed.

Change committed as 242067

Expand Messages | Collapse Messages