Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1166523006: Make EdgeDims and BoxConstraints printable (for debugging) (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
jackson, eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M sky/sdk/lib/framework/rendering/box.dart View 2 chunks +20 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
jackson
lgtm
5 years, 6 months ago (2015-06-03 23:02:13 UTC) #2
eseidel
The hash bits look strange, but the toString looks fine. https://codereview.chromium.org/1166523006/diff/1/sky/sdk/lib/framework/rendering/box.dart File sky/sdk/lib/framework/rendering/box.dart (right): https://codereview.chromium.org/1166523006/diff/1/sky/sdk/lib/framework/rendering/box.dart#newcode42 ...
5 years, 6 months ago (2015-06-03 23:23:17 UTC) #4
Hixie
The hash code is just copying with the matrix code does. Not sure where the ...
5 years, 6 months ago (2015-06-03 23:43:44 UTC) #5
Hixie
5 years, 6 months ago (2015-06-04 00:24:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8fe5c791132e272096f4d467b4e09cb182cc480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698