Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: runtime/lib/double.cc

Issue 1166523005: Fix fix (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: f Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/double.cc
diff --git a/runtime/lib/double.cc b/runtime/lib/double.cc
index 643efb2be78db189903eb5ad251bb0923c5226ad..dbeb44705b81d380aa62b8bcd9b55b976e3ca04e 100644
--- a/runtime/lib/double.cc
+++ b/runtime/lib/double.cc
@@ -304,12 +304,8 @@ DEFINE_NATIVE_ENTRY(Double_getIsNegative, 1) {
DEFINE_NATIVE_ENTRY(Double_flipSignBit, 1) {
const Double& arg = Double::CheckedHandle(arguments->NativeArgAt(0));
const double in_val = arg.value();
- // TODO(srdjan): Fix this compilation error.
- // const int64_t bits =
- // *(reinterpret_cast<const int64_t*>(&in_val)) ^ kSignBitDouble;
- // const double out_val = *(reinterpret_cast<const double*>(&bits));
- // return Double::New(out_val);
- return Double::New(-in_val);
+ const int64_t bits = bit_cast<int64_t, double>(in_val) ^ kSignBitDouble;
+ return Double::New(bit_cast<double, int64_t>(bits));
}
// Add here only functions using/referring to old-style casts.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698