Sync FileSystem: Mark empty batch sync origin as incremental sync origin.

Sync FileSystem: Mark empty batch sync origin as incremental sync origin.

Without this, we have no chance to start polling for new app until we make a local change.

BUG=167739
TEST=DriveFileSyncServiceTest.RegisterNewOrigin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175479

[tzik, 2012-12-26 09:41:45]

PTAL

[kinuko, 2013-01-04 10:38:54]

Can you update the TEST= line to include the updated test name?

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_service.cc (right):

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_service.cc:891:
!ContainsKey(url_to_change_, origin)) {
This is not directly related to this change, but can we rename 'url_to_change_'
(and its type name) to 'origin_to_change_map_' or 'origin_to_changes_'?

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc (left):

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc:371: #if
!defined(OS_ANDROID)
This change looks irrelevant?

[tzik, 2013-01-07 08:37:55]

Thanks! Updated.

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_service.cc (right):

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_service.cc:891:
!ContainsKey(url_to_change_, origin)) {
On 2013/01/04 10:38:54, kinuko wrote:
> This is not directly related to this change, but can we rename
'url_to_change_'
> (and its type name) to 'origin_to_change_map_' or 'origin_to_changes_'?

Let me rename to 'origin_to_changes_map_'.
Its type is Origin -> Path -> Change or (Origin, Path) -> Change.

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc (left):

https://codereview.chromium.org/11665029/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_file_sync_service_unittest.cc:371: #if
!defined(OS_ANDROID)
On 2013/01/04 10:38:54, kinuko wrote:
> This change looks irrelevant?

Reverted. It's not related to the change.

[kinuko, 2013-01-07 09:28:30]

lgtm

https://codereview.chromium.org/11665029/diff/8001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service.cc (right):

https://codereview.chromium.org/11665029/diff/8001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service.cc:890: if
(metadata_store_->IsBatchSyncOrigin(origin) &&
nit: can you add a brief comment like: 'Move the origin to incremental sync if
it has no changes'

[tzik, 2013-01-07 11:16:14]

https://codereview.chromium.org/11665029/diff/8001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service.cc (right):

https://codereview.chromium.org/11665029/diff/8001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service.cc:890: if
(metadata_store_->IsBatchSyncOrigin(origin) &&
On 2013/01/07 09:28:31, kinuko wrote:
> nit: can you add a brief comment like: 'Move the origin to incremental sync if
> it has no changes'

Done.

[commit-bot: I haz the power, 2013-01-07 11:16:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/11665029/9004

[commit-bot: I haz the power, 2013-01-07 11:30:47]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 15:53:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/11665029/9004

[commit-bot: I haz the power, 2013-01-07 17:41:32]

Retried try job too often on win_aura for step(s) interactive_ui_tests