Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1166473005: Add BlockContainer to fn2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson_old, eseidel
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add BlockContainer to fn2 BlockContainer uses a RenderBlock to lay out its children. R=eseidel@chromium.org, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ab58c8fd13cf329a3cf10b801059b82e0463b278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M sky/examples/fn2/container.dart View 1 chunk +5 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-02 17:23:08 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-02 18:08:07 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-02 19:19:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab58c8fd13cf329a3cf10b801059b82e0463b278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698