Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: ppapi/proxy/ppapi_proxy_test.cc

Issue 1166443004: Further clean up pepper's use of SharedMemory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shared_memory_make_class3_base
Patch Set: Fix compile error on windows. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/ppapi_proxy_test.cc
diff --git a/ppapi/proxy/ppapi_proxy_test.cc b/ppapi/proxy/ppapi_proxy_test.cc
index 2b0667c6dbbee332408df8ec354cbcd42c208256..3d9868b5f2e6dd0562751ae0f352883fa76a5dbf 100644
--- a/ppapi/proxy/ppapi_proxy_test.cc
+++ b/ppapi/proxy/ppapi_proxy_test.cc
@@ -259,14 +259,8 @@ PluginProxyTestHarness::PluginDelegateMock::ShareHandleWithRemote(
base::SharedMemoryHandle
PluginProxyTestHarness::PluginDelegateMock::ShareSharedMemoryHandleWithRemote(
const base::SharedMemoryHandle& handle,
- base::ProcessId remote_pid) {
-#if defined(OS_POSIX)
- return ShareHandleWithRemote(handle.fd, remote_pid, false);
-#elif defined(OS_WIN)
- return ShareHandleWithRemote(handle, remote_pid, false);
-#else
-#error Not implemented.
-#endif
+ base::ProcessId /* remote_pid */) {
+ return base::SharedMemory::DuplicateHandle(handle);
}
std::set<PP_Instance>*
@@ -505,14 +499,8 @@ HostProxyTestHarness::DelegateMock::ShareHandleWithRemote(
base::SharedMemoryHandle
HostProxyTestHarness::DelegateMock::ShareSharedMemoryHandleWithRemote(
const base::SharedMemoryHandle& handle,
- base::ProcessId remote_pid) {
-#if defined(OS_POSIX)
- return ShareHandleWithRemote(handle.fd, remote_pid, false);
-#elif defined(OS_WIN)
- return ShareHandleWithRemote(handle, remote_pid, false);
-#else
-#error Not implemented.
-#endif
+ base::ProcessId /*remote_pid*/) {
+ return base::SharedMemory::DuplicateHandle(handle);
}
// HostProxyTest ---------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698