Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1166433007: [strong] fix strong object exception messages (Closed)

Created:
5 years, 6 months ago by conradw
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] fix strong object exception messages A mistake in a recent CL has messed up the error messages for strong object semantics. BUG= LOG=N Committed: https://crrev.com/ea2cb139d6064e2a692258cc62bf444cd9023bcd Cr-Commit-Position: refs/heads/master@{#28741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M src/messages.h View 1 chunk +2 lines, -3 lines 0 comments Download
A + test/message/strong-object-freeze-prop.js View 1 chunk +5 lines, -4 lines 0 comments Download
A test/message/strong-object-freeze-prop.out View 1 chunk +9 lines, -0 lines 0 comments Download
A + test/message/strong-object-set-proto.js View 1 chunk +4 lines, -4 lines 0 comments Download
A test/message/strong-object-set-proto.out View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
conradw
PTAL apologies for the spam, uploaded the wrong version
5 years, 6 months ago (2015-06-01 20:06:29 UTC) #2
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-01 20:18:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166433007/1
5 years, 6 months ago (2015-06-01 20:40:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 22:43:56 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 22:44:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea2cb139d6064e2a692258cc62bf444cd9023bcd
Cr-Commit-Position: refs/heads/master@{#28741}

Powered by Google App Engine
This is Rietveld 408576698