Issue 1166433004: Re-enable on-heap typed array allocation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1166433004: Re-enable on-heap typed array allocation (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Re-enable on-heap typed array allocation BUG=v8:3996 R=mstarzinger@chromium.org LOG=y Committed: https://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475 Cr-Commit-Position: refs/heads/master@{#28722}

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View		2 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Starzinger

LGTM. I don't even have a snarky comment for this. This is exceeding the scale ...

5 years, 6 months ago (2015-06-01 09:25:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166433004/1

5 years, 6 months ago (2015-06-01 09:25:44 UTC) #4

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f91df1f25dec4f1982c40af6118da8b699777475 Cr-Commit-Position: refs/heads/master@{#28722}

5 years, 6 months ago (2015-06-01 10:07:33 UTC) #6

Benedikt Meurer

5 years, 6 months ago (2015-06-01 10:58:37 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1158193004/ by bmeurer@chromium.org.

The reason for reverting is: Win32 breakage.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages