content/browser/service_worker/service_worker_provider_host.h - Issue 1166433003: Service Worker: Don't write to disk during update until proven necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.h

Issue 1166433003: Service Worker: Don't write to disk during update until proven necessary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_request_handler.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.h

diff --git a/content/browser/service_worker/service_worker_provider_host.h b/content/browser/service_worker/service_worker_provider_host.h

index c2140d5775fd694cbd2a022ed3c4f56817f18949..0af23c1239af8a3cf3429ed00250c51ddd63d4be 100644

--- a/content/browser/service_worker/service_worker_provider_host.h

+++ b/content/browser/service_worker/service_worker_provider_host.h

@@ -228,6 +228,15 @@ class CONTENT_EXPORT ServiceWorkerProviderHost

private:

friend class ServiceWorkerProviderHostTest;

friend class ServiceWorkerWriteToCacheJobTest;

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest, Update_SameScript);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest,

+ Update_SameSizeScript);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest,

+ Update_TruncatedScript);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest,

+ Update_ElongatedScript);

+ FRIEND_TEST_ALL_PREFIXES(ServiceWorkerWriteToCacheJobTest,

+ Update_EmptyScript);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,

UpdateBefore24Hours);

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,