Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/history/history_unittest.cc

Issue 11664013: GTTF: No more FLAKY_ . (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // History unit tests come in two flavors: 5 // History unit tests come in two flavors:
6 // 6 //
7 // 1. The more complicated style is that the unit test creates a full history 7 // 1. The more complicated style is that the unit test creates a full history
8 // service. This spawns a background thread for the history backend, and 8 // service. This spawns a background thread for the history backend, and
9 // all communication is asynchronous. This is useful for testing more 9 // all communication is asynchronous. This is useful for testing more
10 // complicated things or end-to-end behavior. 10 // complicated things or end-to-end behavior.
(...skipping 690 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 701
702 // Make sure nothing got written. 702 // Make sure nothing got written.
703 EXPECT_FALSE(QueryURL(history_service_.get(), nonexistent_url)); 703 EXPECT_FALSE(QueryURL(history_service_.get(), nonexistent_url));
704 EXPECT_EQ(string16(), query_url_row_.title()); 704 EXPECT_EQ(string16(), query_url_row_.title());
705 705
706 // TODO(brettw) this should also test redirects, which get the title of the 706 // TODO(brettw) this should also test redirects, which get the title of the
707 // destination page. 707 // destination page.
708 } 708 }
709 709
710 // crbug.com/159387: This test fails when daylight savings time ends. 710 // crbug.com/159387: This test fails when daylight savings time ends.
711 TEST_F(HistoryTest, FLAKY_Segments) { 711 TEST_F(HistoryTest, DISABLED_Segments) {
712 ASSERT_TRUE(history_service_.get()); 712 ASSERT_TRUE(history_service_.get());
713 713
714 static const void* scope = static_cast<void*>(this); 714 static const void* scope = static_cast<void*>(this);
715 715
716 // Add a URL. 716 // Add a URL.
717 const GURL existing_url("http://www.google.com/"); 717 const GURL existing_url("http://www.google.com/");
718 history_service_->AddPage( 718 history_service_->AddPage(
719 existing_url, base::Time::Now(), scope, 0, GURL(), 719 existing_url, base::Time::Now(), scope, 0, GURL(),
720 history::RedirectList(), content::PAGE_TRANSITION_TYPED, 720 history::RedirectList(), content::PAGE_TRANSITION_TYPED,
721 history::SOURCE_BROWSED, false); 721 history::SOURCE_BROWSED, false);
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 1175
1176 history_service_->StopSyncing(syncer::HISTORY_DELETE_DIRECTIVES); 1176 history_service_->StopSyncing(syncer::HISTORY_DELETE_DIRECTIVES);
1177 EXPECT_TRUE( 1177 EXPECT_TRUE(
1178 history_service_->ProcessLocalDeleteDirective(delete_directive).IsSet()); 1178 history_service_->ProcessLocalDeleteDirective(delete_directive).IsSet());
1179 EXPECT_EQ(1u, change_processor.GetChanges().size()); 1179 EXPECT_EQ(1u, change_processor.GetChanges().size());
1180 } 1180 }
1181 1181
1182 } // namespace 1182 } // namespace
1183 1183
1184 } // namespace history 1184 } // namespace history
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698