Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 11664013: GTTF: No more FLAKY_ . (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 6
7 #include "chrome/browser/prefs/incognito_mode_prefs.h" 7 #include "chrome/browser/prefs/incognito_mode_prefs.h"
8 #include "chrome/browser/prefs/pref_service.h" 8 #include "chrome/browser/prefs/pref_service.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 prefs::kHomePageIsNewTabPage, true); 80 prefs::kHomePageIsNewTabPage, true);
81 81
82 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud.html")) << message_; 82 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud.html")) << message_;
83 } 83 }
84 84
85 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Tabs2) { 85 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Tabs2) {
86 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud2.html")) << message_; 86 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "crud2.html")) << message_;
87 } 87 }
88 88
89 // crbug.com/149924 89 // crbug.com/149924
90 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, FLAKY_TabDuplicate) { 90 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_TabDuplicate) {
91 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "duplicate.html")) << message_; 91 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "duplicate.html")) << message_;
92 } 92 }
93 93
94 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabUpdate) { 94 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabUpdate) {
95 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "update.html")) << message_; 95 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "update.html")) << message_;
96 } 96 }
97 97
98 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabPinned) { 98 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, TabPinned) {
99 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "pinned.html")) << message_; 99 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "pinned.html")) << message_;
100 } 100 }
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 << message_; 240 << message_;
241 } 241 }
242 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) { 242 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_GetViewsOfCreatedWindow) {
243 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html")) 243 ASSERT_TRUE(RunExtensionSubtest("tabs/basics", "get_views_window.html"))
244 << message_; 244 << message_;
245 } 245 }
246 246
247 // Adding a new test? Awesome. But API tests are the old hotness. The 247 // Adding a new test? Awesome. But API tests are the old hotness. The
248 // new hotness is extension_test_utils. See tabs_test.cc for an example. 248 // new hotness is extension_test_utils. See tabs_test.cc for an example.
249 // We are trying to phase out many uses of API tests as they tend to be flaky. 249 // We are trying to phase out many uses of API tests as they tend to be flaky.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698