Add a mechanism to ignore certain elements for accessibility audit on a per-test basis.

chrome/test/data/webui/accessibility_audit_browsertest.js

Index: chrome/test/data/webui/accessibility_audit_browsertest.js
diff --git a/chrome/test/data/webui/accessibility_audit_browsertest.js b/chrome/test/data/webui/accessibility_audit_browsertest.js
index 9af61c0f2980b72c31409f67ac2e0171230116c4..35c2c806c79c77ef922ccfb1b9da802cc0ed285a 100644
--- a/chrome/test/data/webui/accessibility_audit_browsertest.js
+++ b/chrome/test/data/webui/accessibility_audit_browsertest.js
@@ -38,6 +38,9 @@ WebUIAccessibilityAuditBrowserTest.prototype = {
    */
   expectedErrors: null,
 
+  isAsync: false,
+  accessibilityAuditConfig: new axs.AuditConfiguration(),
+
   tearDown: function() {
     if (this.expectedErrors != null)
       expectEquals(this.expectedErrors, this.getAccessibilityErrors().length);
@@ -119,7 +122,7 @@ function expectAuditWillNotRun() {
 function expectAuditWillRun(times) {
   var audit = createMockAudit();
   var realAudit = axs.Audit;
-  var expectedInvocation = audit.expects(exactly(times)).run();
+  var expectedInvocation = audit.expects(exactly(times)).run(ANYTHING);
   var willArgs = [];
   for (var i = 0; i < times; i++)
     willArgs.push(callFunction(realAudit.run));
@@ -188,7 +191,6 @@ TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture',
 TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture',
        'testWithAuditFailures_shouldFail',
        function() {
-         console.log(axs.Audit);
   expectAuditWillRun(1);
   this.enableAccessibilityChecks();
   addAuditFailures();
@@ -282,3 +284,36 @@ TEST_F('WebUIAccessibilityAuditBrowserTest_IssuesAreWarnings',
 
   addAuditFailures();
 });
+
+// Tests that parts of the page can be ignored on a per-audit rule basis.
+TEST_F('WebUIAccessibilityAuditBrowserTest_IssuesAreWarnings',
+       'testCanIgnoreSelectors',
+        function() {
+  this.disableAccessibilityChecks();
+  expectAuditWillRun(2);
+
+  addAuditFailures();
+  var accessibilityErrors = [];
+  var accessibilityWarnings = [];
+  try {
+    assertAccessibilityOk(accessibilityErrors, accessibilityWarnings);
+  } catch (e) {
+  }
+  expectEquals(2, accessibilityErrors.length);
+  expectEquals(1, accessibilityWarnings.length);
+
+  accessibilityErrors.splice(0, accessibilityErrors.length);

[dmazzoni, 2012/12/21 23:21:03]

I saw this pattern before - any reason not to just do this?

accessibilityErrors.length = 0;

[aboxhall, 2013/01/16 00:01:42]

Not at all. Changed.

+  accessibilityWarnings.splice(0, accessibilityWarnings.length);
+  assertEquals(0, accessibilityErrors.length);
+  assertEquals(0, accessibilityWarnings.length);
+
+  this.accessibilityAuditConfig.ignoreSelectors('lowContrastElements', 'P');
+
+  try {
+    assertAccessibilityOk(accessibilityErrors, accessibilityWarnings);
+  } catch (e) {
+  }
+  expectEquals(2, accessibilityErrors.length);
+  // lowContrastElements should pass as the failing element is ignored.
+  expectEquals(0, accessibilityWarnings.length);
+});