Add a mechanism to ignore certain elements for accessibility audit on a per-test basis.

chrome/test/data/webui/accessibility_audit_browsertest.js

-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Tests to ensure that the accessibility audit and mechanisms
  * to enable/disable it work as expected.
  * @author aboxhall@google.com (Alice Boxhall)
  * @see test_api.js
  */
 
@@ skipping 19 matching lines @@
    */
   expectedWarnings: null,
 
   /**
    * Number of expected accessibility warnings, if it should be checked,
    * otherwise null.
    * @type {?number}
    */
   expectedErrors: null,
 
+  isAsync: false,
+
   tearDown: function() {
     if (this.expectedErrors != null)
       expectEquals(this.expectedErrors, this.getAccessibilityErrors().length);
     if (this.expectedWarnings != null) {
       expectEquals(this.expectedWarnings,
                    this.getAccessibilityWarnings().length);
     }
     testing.Test.prototype.tearDown.call(this);
   }
 };
@@ skipping 73 matching lines @@
 /**
  * Creates an expectation that the global axs.Audit object will have its run()
  * method called |times| times.
  * This creates an interstitial mock axs.Audit object with the expectation, and
  * delegates to the real axs.Audit object to run the actual audit.
  * @param {number} times The number of times the audit is expected to run.
  */
 function expectAuditWillRun(times) {
   var audit = createMockAudit();
   var realAudit = axs.Audit;
-  var expectedInvocation = audit.expects(exactly(times)).run();
+  var expectedInvocation = audit.expects(exactly(times)).run(ANYTHING);
   var willArgs = [];
   for (var i = 0; i < times; i++)
     willArgs.push(callFunction(realAudit.run));
   expectedInvocation.will.apply(expectedInvocation, willArgs);
   axs.Audit = audit.proxy();
 }
 
-// Tests that an audit failure causes a test failure, if both
+// Test that an audit failure causes a test failure, if both
 // |runAccessibilityChecks| and |accessibilityIssuesAreErrors| are true.
 TEST_F('WebUIAccessibilityAuditBrowserTest_ShouldFail', 'testWithAuditFailures',
        function() {
   expectAuditWillRun(1);
   addAuditFailures();
 });
 
-// Tests that the accessibility audit does not run if |runAccessibilityChecks|
+// Test that the accessibility audit does not run if |runAccessibilityChecks|
 // is false.
 TEST_F('WebUIAccessibilityAuditBrowserTest',
        'testWithAuditFailures_a11yChecksDisabled',
        function() {
   expectAuditWillNotRun();
   this.disableAccessibilityChecks();
   addAuditFailures();
 });
 
 // Tests that the accessibility audit will run but not cause a test failure when
@@ skipping 37 matching lines @@
 WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture_ShouldFail.prototype =
 {
   __proto__:
       WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture.prototype,
 
   testShouldFail: true
 };
 
 
 
-// Tests that the accessibility audit does not run when |runAccessibilityChecks|
+// Test that the accessibility audit does not run when |runAccessibilityChecks|
 // is set to false in the test fixture.
 TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture',
        'testWithAuditFailures_a11yChecksNotEnabled',
        function() {
   expectAuditWillNotRun();
   addAuditFailures();
 });
 
-// Tests that the accessibility audit does run if the
-// enableAccessibilityChecks() method is called in the test function.
+// Test that the accessibility audit does run if the enableAccessibilityChecks()
+// method is called in the test function.
 TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture_ShouldFail',
        'testWithAuditFailures',
        function() {
-         console.log(axs.Audit);
   expectAuditWillRun(1);
   this.enableAccessibilityChecks();
   addAuditFailures();
 });
 
-// Tests that the accessibility audit runs when the expectAccessibilityOk()
+// Test that the accessibility audit runs when the expectAccessibilityOk()
 // method is called.
 TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture',
        'testRunningAuditManually_noErrors',
        function() {
   expectAuditWillRun(1);
   expectAccessibilityOk();
 });
 
-// Tests that calling expectAccessibilityOk() when there are accessibility
-// issues on the page causes the test to fail.
+// Test that calling expectAccessibilityOk() when there are accessibility issues
+// on the page causes the test to fail.
 TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture_ShouldFail',
        'testRunningAuditManually_withErrors',
        function() {
   expectAuditWillRun(1);
   addAuditFailures();
   expectAccessibilityOk();
 });
 
-// Tests that calling expectAccessibilityOk() multiple times will cause the
+// Test that calling expectAccessibilityOk() multiple times will cause the
 // accessibility audit to run multiple times.
 TEST_F('WebUIAccessibilityAuditBrowserTest_TestsDisabledInFixture',
        'testRunningAuditManuallySeveralTimes', function() {
   expectAuditWillRun(2);
   expectAccessibilityOk();
   expectAccessibilityOk();
 });
 
 /**
  * Test fixture with |accessibilityIssuesAreErrors| set to false.
@@ skipping 63 matching lines @@
   expectAccessibilityOk();
 
   this.expectedWarnings = 1;
   this.expectedErrors = 2;
   expectReportConsoleWarning();
 
   this.enableAccessibilityChecks();
 
   addAuditFailures();
 });
+
+// Tests that parts of the page can be ignored on a per-audit rule basis.
+TEST_F('WebUIAccessibilityAuditBrowserTest_IssuesAreWarnings',
+       'testCanIgnoreSelectors',
+        function() {
+  this.disableAccessibilityChecks();
+
+  addAuditFailures();
+  var accessibilityErrors = [];
+  var accessibilityWarnings = [];
+  try {
+    assertAccessibilityOk(accessibilityErrors, accessibilityWarnings);
+  } catch (e) {
+    // Expected error from assertion
+  }
+  expectEquals(2, accessibilityErrors.length);
+  expectEquals(1, accessibilityWarnings.length);
+
+  accessibilityErrors.length = 0;
+  accessibilityWarnings.length = 0;
+
+  this.accessibilityAuditConfig.ignoreSelectors('lowContrastElements', 'P');
+  try {
+    assertAccessibilityOk(accessibilityErrors, accessibilityWarnings);
+  } catch (e) {
+    // Expected error from assertion
+  }
+  expectEquals(2, accessibilityErrors.length);
+  // lowContrastElements should pass as the failing element is ignored.
+  expectEquals(0, accessibilityWarnings.length);
+});