Add a mechanism to ignore certain elements for accessibility audit on a per-test basis.

Add a mechanism to ignore certain elements for accessibility audit on a per-test basis.

BUG=162740
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177520

[dmazzoni, 2012-12-21 20:00:35]

I think Rietveld didn't pick up on all of the changes...

https://codereview.chromium.org/11664011/diff/1/chrome/test/data/webui/access...
File chrome/test/data/webui/accessibility_audit_browsertest.js (right):

https://codereview.chromium.org/11664011/diff/1/chrome/test/data/webui/access...
chrome/test/data/webui/accessibility_audit_browsertest.js:288: // Tests that the
accessibility audit will run twice if expectAccessibilityOk()
Update this comment

https://codereview.chromium.org/11664011/diff/1/chrome/test/data/webui/access...
chrome/test/data/webui/accessibility_audit_browsertest.js:295: //
lowContrastElements should pass as the failing element is ignored.
Would it be possible to make this test self-contained,
rather than relative to another test?

I'd prefer something like:
1. Run the test normally, expect 1 warning
2. Ignore selectors
3. Run the test again, this time expect 0 warnings

[aboxhall, 2012-12-21 23:11:56]

On 2012/12/21 20:00:35, Dominic Mazzoni wrote:
> I think Rietveld didn't pick up on all of the changes...

I think the problem was that I'd done funny things locally with
third_party/accessibility-developer-tools. Hopefully this patch fixes that up.

[aboxhall, 2012-12-21 23:12:03]

https://codereview.chromium.org/11664011/diff/1/chrome/test/data/webui/access...
File chrome/test/data/webui/accessibility_audit_browsertest.js (right):

https://codereview.chromium.org/11664011/diff/1/chrome/test/data/webui/access...
chrome/test/data/webui/accessibility_audit_browsertest.js:288: // Tests that the
accessibility audit will run twice if expectAccessibilityOk()
On 2012/12/21 20:00:35, Dominic Mazzoni wrote:
> Update this comment

Done.

https://codereview.chromium.org/11664011/diff/1/chrome/test/data/webui/access...
chrome/test/data/webui/accessibility_audit_browsertest.js:295: //
lowContrastElements should pass as the failing element is ignored.
On 2012/12/21 20:00:35, Dominic Mazzoni wrote:
> Would it be possible to make this test self-contained,
> rather than relative to another test?
> 
> I'd prefer something like:
> 1. Run the test normally, expect 1 warning
> 2. Ignore selectors
> 3. Run the test again, this time expect 0 warnings

Done.

[dmazzoni, 2012-12-21 23:21:03]

lgtm

https://codereview.chromium.org/11664011/diff/3002/chrome/test/data/webui/acc...
File chrome/test/data/webui/accessibility_audit_browsertest.js (right):

https://codereview.chromium.org/11664011/diff/3002/chrome/test/data/webui/acc...
chrome/test/data/webui/accessibility_audit_browsertest.js:305:
accessibilityErrors.splice(0, accessibilityErrors.length);
I saw this pattern before - any reason not to just do this?

accessibilityErrors.length = 0;

[aboxhall, 2013-01-16 00:01:41]

https://codereview.chromium.org/11664011/diff/3002/chrome/test/data/webui/acc...
File chrome/test/data/webui/accessibility_audit_browsertest.js (right):

https://codereview.chromium.org/11664011/diff/3002/chrome/test/data/webui/acc...
chrome/test/data/webui/accessibility_audit_browsertest.js:305:
accessibilityErrors.splice(0, accessibilityErrors.length);
On 2012/12/21 23:21:03, Dominic Mazzoni wrote:
> I saw this pattern before - any reason not to just do this?
> 
> accessibilityErrors.length = 0;

Not at all. Changed.

[commit-bot: I haz the power, 2013-01-16 00:03:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/11664011/17006

[commit-bot: I haz the power, 2013-01-16 00:03:22]

Presubmit check for 11664011-17006 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[aboxhall, 2013-01-16 00:14:19]

jhawkins, would you mind reviewing changes to js_unittest_*.gypi?

[James Hawkins, 2013-01-17 19:27:33]

lgtm

[commit-bot: I haz the power, 2013-01-17 20:18:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aboxhall@chromium.org/11664011/17006

[commit-bot: I haz the power, 2013-01-17 23:08:39]

Change committed as 177520