chrome/browser/extensions/api/declarative_content/content_condition.h - Issue 1166393002: Reland "Encapsulate CSS selector declarative content condition tracking"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_condition.h

Issue 1166393002: Reland "Encapsulate CSS selector declarative content condition tracking" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: crash fixes and tests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/content_action.h ('k') | chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc » ('j') | chrome/browser/extensions/tab_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_condition.h

diff --git a/chrome/browser/extensions/api/declarative_content/content_condition.h b/chrome/browser/extensions/api/declarative_content/content_condition.h

index 134fa8c96b4f1734a6d6cbfbd78d5f6dc386c426..b8c92f280ad808e54f6262260d700469f241c7bd 100644

--- a/chrome/browser/extensions/api/declarative_content/content_condition.h

+++ b/chrome/browser/extensions/api/declarative_content/content_condition.h

@@ -5,7 +5,6 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_CONDITION_H_

#define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_CONDITION_H_

-#include <map>

#include <set>

#include <string>

#include <vector>

@@ -13,12 +12,17 @@

#include "base/containers/hash_tables.h"

#include "base/memory/ref_counted.h"

#include "base/memory/scoped_ptr.h"

-#include "base/values.h"

#include "components/url_matcher/url_matcher.h"

#include "extensions/browser/api/declarative/declarative_rule.h"

+namespace base {

+class Value;

namespace extensions {

+class Extension;

struct RendererContentMatchData {

RendererContentMatchData();

~RendererContentMatchData();