Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1166363002: Position the popup menu in stocks2 correctly (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Position the popup menu in stocks2 correctly This CL pulled an implementation of position: absolute in RenderStackContainer. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b8f58e60f7ca42a30aa1c6f4fbb05f772db3927a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -20 lines) Patch
M sky/examples/stocks2/lib/stock_menu.dart View 2 chunks +12 lines, -13 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 2 chunks +32 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/rendering/flex.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/rendering/stack.dart View 2 chunks +56 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-09 00:41:12 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-09 16:08:14 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-09 16:22:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8f58e60f7ca42a30aa1c6f4fbb05f772db3927a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698