Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: src/deoptimizer.cc

Issue 1166353004: [deoptimizer] Remove uses of TranslationIterator outside the deoptimizer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/deoptimizer.h ('k') | src/frames.cc » ('j') | src/frames.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index f19609a1dd024f8826cbe68ff92e88af3cefda08..a6778100a4426990780b8bde0e3aef3399f92a6b 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -2515,8 +2515,8 @@ TranslatedValue TranslatedValue::NewTagged(TranslatedState* container,
// static
-TranslatedValue TranslatedValue::NewInvalid() {
- return TranslatedValue(nullptr, kInvalid);
+TranslatedValue TranslatedValue::NewInvalid(TranslatedState* container) {
+ return TranslatedValue(container, kInvalid);
}
@@ -2985,7 +2985,7 @@ TranslatedValue TranslatedState::CreateNextTranslatedValue(
case Translation::REGISTER: {
int input_reg = iterator->Next();
- if (registers == nullptr) return TranslatedValue::NewInvalid();
+ if (registers == nullptr) return TranslatedValue::NewInvalid(this);
intptr_t value = registers->GetRegister(input_reg);
if (trace_file != nullptr) {
PrintF(trace_file, "0x%08" V8PRIxPTR " ; %s ", value,
@@ -2997,7 +2997,7 @@ TranslatedValue TranslatedState::CreateNextTranslatedValue(
case Translation::INT32_REGISTER: {
int input_reg = iterator->Next();
- if (registers == nullptr) return TranslatedValue::NewInvalid();
+ if (registers == nullptr) return TranslatedValue::NewInvalid(this);
intptr_t value = registers->GetRegister(input_reg);
if (trace_file != nullptr) {
PrintF(trace_file, "%" V8PRIdPTR " ; %s ", value,
@@ -3008,7 +3008,7 @@ TranslatedValue TranslatedState::CreateNextTranslatedValue(
case Translation::UINT32_REGISTER: {
int input_reg = iterator->Next();
- if (registers == nullptr) return TranslatedValue::NewInvalid();
+ if (registers == nullptr) return TranslatedValue::NewInvalid(this);
intptr_t value = registers->GetRegister(input_reg);
if (trace_file != nullptr) {
PrintF(trace_file, "%" V8PRIuPTR " ; %s (uint)", value,
@@ -3020,7 +3020,7 @@ TranslatedValue TranslatedState::CreateNextTranslatedValue(
case Translation::BOOL_REGISTER: {
int input_reg = iterator->Next();
- if (registers == nullptr) return TranslatedValue::NewInvalid();
+ if (registers == nullptr) return TranslatedValue::NewInvalid(this);
intptr_t value = registers->GetRegister(input_reg);
if (trace_file != nullptr) {
PrintF(trace_file, "%" V8PRIdPTR " ; %s (bool)", value,
@@ -3031,7 +3031,7 @@ TranslatedValue TranslatedState::CreateNextTranslatedValue(
case Translation::DOUBLE_REGISTER: {
int input_reg = iterator->Next();
- if (registers == nullptr) return TranslatedValue::NewInvalid();
+ if (registers == nullptr) return TranslatedValue::NewInvalid(this);
double value = registers->GetDoubleRegister(input_reg);
if (trace_file != nullptr) {
PrintF(trace_file, "%e ; %s (bool)", value,
« no previous file with comments | « src/deoptimizer.h ('k') | src/frames.cc » ('j') | src/frames.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698