Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issue 1166353004: [deoptimizer] Remove uses of TranslationIterator outside the deoptimizer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Remove uses of TranslationIterator outside the deoptimizer. Use the new TranslatedState and friends, which work at a higher level than the TranslationIterator, which will make it easier to change the deoptimization commands in subsequent CLs. R=jarin@chromium.org Committed: https://crrev.com/e044f0a67e03ad55d447d0a28cc227587515bc5b Cr-Commit-Position: refs/heads/master@{#28862}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -117 lines) Patch
M src/deoptimizer.h View 4 chunks +14 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/frames.cc View 2 chunks +48 lines, -105 lines 1 comment Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-09 12:02:07 UTC) #1
Benedikt Meurer
Hey Jaro, This is preliminary cleanup for the deoptimizer. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-09 12:02:40 UTC) #2
Jarin
lgtm. https://codereview.chromium.org/1166353004/diff/1/src/frames.cc File src/frames.cc (right): https://codereview.chromium.org/1166353004/diff/1/src/frames.cc#newcode889 src/frames.cc:889: TranslatedState state(this); I am wondering whether we should ...
5 years, 6 months ago (2015-06-09 12:32:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166353004/1
5 years, 6 months ago (2015-06-09 13:08:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 13:10:16 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 13:10:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e044f0a67e03ad55d447d0a28cc227587515bc5b
Cr-Commit-Position: refs/heads/master@{#28862}

Powered by Google App Engine
This is Rietveld 408576698