Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: src/code-stubs.h

Issue 11663005: Adapt Danno's Track Allocation Info idea to fast literals. When allocating a literal array, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Always use in ICs, and moved feature behind a flag Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index ae113f5729a58d26bcdfeffff0ee5011a2570954..a3bba6eae658e5a775abcfc4c9dfc2c7d739767d 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -386,7 +386,8 @@ class FastCloneShallowArrayStub : public CodeStub {
CLONE_ELEMENTS,
CLONE_DOUBLE_ELEMENTS,
COPY_ON_WRITE_ELEMENTS,
- CLONE_ANY_ELEMENTS
+ CLONE_ANY_ELEMENTS,
+ CLONE_ANY_ELEMENTS_WITH_ALLOCATION_INFO
danno 2012/12/26 10:32:01 Add LAST_CLONE_MODE = CLONE_ANY_ELEMENTS_WITH_ALLO
mvstanton 2013/01/03 14:40:43 Done.
};
FastCloneShallowArrayStub(Mode mode, int length)
@@ -404,8 +405,9 @@ class FastCloneShallowArrayStub : public CodeStub {
Major MajorKey() { return FastCloneShallowArray; }
int MinorKey() {
- ASSERT(mode_ == 0 || mode_ == 1 || mode_ == 2 || mode_ == 3);
- return length_ * 4 + mode_;
+ ASSERT(mode_ == 0 || mode_ == 1 || mode_ == 2 || mode_ == 3 ||
danno 2012/12/26 10:32:01 While you're here, how about adding a constant con
mvstanton 2013/01/03 14:40:43 Done.
+ mode_ == 4);
+ return length_ * 5 + mode_;
danno 2012/12/26 10:32:01 return length_ * kFastCloneModeCount + mode_;
mvstanton 2013/01/03 14:40:43 Done.
}
};
« no previous file with comments | « include/v8.h ('k') | src/flag-definitions.h » ('j') | src/ia32/code-stubs-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698