Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 11663005: Adapt Danno's Track Allocation Info idea to fast literals. When allocating a literal array, (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: A few more review comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3033 matching lines...) Expand 10 before | Expand all | Expand 10 after
3044 // object we've reached through the prototype chain. 3044 // object we've reached through the prototype chain.
3045 mov(ecx, FieldOperand(ecx, JSObject::kElementsOffset)); 3045 mov(ecx, FieldOperand(ecx, JSObject::kElementsOffset));
3046 cmp(ecx, isolate()->factory()->empty_fixed_array()); 3046 cmp(ecx, isolate()->factory()->empty_fixed_array());
3047 j(not_equal, call_runtime); 3047 j(not_equal, call_runtime);
3048 3048
3049 mov(ecx, FieldOperand(ebx, Map::kPrototypeOffset)); 3049 mov(ecx, FieldOperand(ebx, Map::kPrototypeOffset));
3050 cmp(ecx, isolate()->factory()->null_value()); 3050 cmp(ecx, isolate()->factory()->null_value());
3051 j(not_equal, &next); 3051 j(not_equal, &next);
3052 } 3052 }
3053 3053
3054
3055 void MacroAssembler::TestJSArrayForAllocationSiteInfo(
3056 Register receiver_reg,
3057 Register scratch_reg,
3058 Label* allocation_info_present) {
3059 Label no_info_available;
3060 ExternalReference new_space_start =
3061 ExternalReference::new_space_start(isolate());
3062 ExternalReference new_space_allocation_top =
3063 ExternalReference::new_space_allocation_top_address(isolate());
3064
3065 lea(scratch_reg, Operand(receiver_reg,
3066 JSArray::kSize + AllocationSiteInfo::kSize));
3067 cmp(scratch_reg, Immediate(new_space_start));
3068 j(less, &no_info_available);
3069 cmp(scratch_reg, Operand::StaticVariable(new_space_allocation_top));
3070 j(greater_equal, &no_info_available);
3071 cmp(MemOperand(scratch_reg, 0),
3072 Immediate(Handle<Map>(isolate()->heap()->allocation_site_info_map())));
3073 j(equal, allocation_info_present);
3074 bind(&no_info_available);
3075 }
3076
3077
3054 } } // namespace v8::internal 3078 } } // namespace v8::internal
3055 3079
3056 #endif // V8_TARGET_ARCH_IA32 3080 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698