Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1166293004: Make RawMachineAssemblerTest emitting CFG always have a dummy End block (Closed)

Created:
5 years, 6 months ago by Weiliang
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make RawMachineAssemblerTest emitting CFG always have a dummy End block Frame Elider requires a sane CFG which should have such dummy end block. BUG= Committed: https://crrev.com/fa041c90df56476e195b6b3fe0f9e4f732c8bc7b Cr-Commit-Position: refs/heads/master@{#28911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -50 lines) Patch
M src/compiler/raw-machine-assembler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 12 chunks +31 lines, -41 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Weiliang
PTAL
5 years, 6 months ago (2015-06-10 17:00:22 UTC) #2
Michael Starzinger
LGTM.
5 years, 6 months ago (2015-06-10 17:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166293004/1
5 years, 6 months ago (2015-06-10 17:08:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166293004/1
5 years, 6 months ago (2015-06-10 17:09:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 17:37:37 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 17:37:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa041c90df56476e195b6b3fe0f9e4f732c8bc7b
Cr-Commit-Position: refs/heads/master@{#28911}

Powered by Google App Engine
This is Rietveld 408576698