Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1166283006: ServiceWorker: Implement ServiceWorkerRegistration.update() (1) (Closed)

Created:
4 years, 10 months ago by nhiroki
Modified:
4 years, 10 months ago
Reviewers:
falken, tkent
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 : #

Messages

Total messages: 14 (4 generated)
nhiroki
PTAL, thanks!
4 years, 10 months ago (2015-06-10 03:37:07 UTC) #3
falken
lgtm Please link to the intent to ship in CL description (and also the bug)
4 years, 10 months ago (2015-06-10 03:55:03 UTC) #4
nhiroki
On 2015/06/10 03:55:03, falken wrote: > lgtm > > Please link to the intent to ...
4 years, 10 months ago (2015-06-10 04:09:09 UTC) #5
nhiroki
+tkent@, can you review public/platform/? Thanks!
4 years, 10 months ago (2015-06-10 04:09:58 UTC) #7
tkent
lgtm
4 years, 10 months ago (2015-06-10 04:30:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166283006/20001
4 years, 10 months ago (2015-06-10 06:40:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=196838
4 years, 10 months ago (2015-06-10 06:43:43 UTC) #11
nhiroki
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/1178753003/ by nhiroki@chromium.org. ...
4 years, 10 months ago (2015-06-11 04:19:03 UTC) #12
kinuko
On 2015/06/11 04:19:03, nhiroki wrote: > A revert of this CL (patchset #1 id:20001) has ...
4 years, 10 months ago (2015-06-11 04:22:48 UTC) #13
nhiroki
4 years, 10 months ago (2015-06-11 04:33:39 UTC) #14
Message was sent while issue was closed.
On 2015/06/11 04:22:48, kinuko wrote:
> On 2015/06/11 04:19:03, nhiroki wrote:
> > A revert of this CL (patchset #1 id:20001) has been created in
> > https://codereview.chromium.org/1178753003/ by mailto:nhiroki@chromium.org.
> > 
> > The reason for reverting is: I'll remake this CL as per the discussion in
the
> > CL(2)..
> 
> It's ok but not sure if you needed to revert? Looks like we could just change
on
> top of it.

No special reason, just to rollback the change. Yes, we were able to make a
change on top of that.

Powered by Google App Engine
This is Rietveld 408576698