4 years, 10 months ago
(2015-06-10 03:37:07 UTC)
#3
PTAL, thanks!
falken
lgtm Please link to the intent to ship in CL description (and also the bug)
4 years, 10 months ago
(2015-06-10 03:55:03 UTC)
#4
lgtm
Please link to the intent to ship in CL description (and also the bug)
nhiroki
On 2015/06/10 03:55:03, falken wrote: > lgtm > > Please link to the intent to ...
4 years, 10 months ago
(2015-06-10 04:09:09 UTC)
#5
On 2015/06/10 03:55:03, falken wrote:
> lgtm
>
> Please link to the intent to ship in CL description (and also the bug)
Thank you for reviewing! Updated the CL description and the bug.
On 2015/06/11 04:19:03, nhiroki wrote: > A revert of this CL (patchset #1 id:20001) has ...
4 years, 10 months ago
(2015-06-11 04:22:48 UTC)
#13
Message was sent while issue was closed.
On 2015/06/11 04:19:03, nhiroki wrote:
> A revert of this CL (patchset #1 id:20001) has been created in
> https://codereview.chromium.org/1178753003/ by mailto:nhiroki@chromium.org.
>
> The reason for reverting is: I'll remake this CL as per the discussion in the
> CL(2)..
It's ok but not sure if you needed to revert? Looks like we could just change on
top of it.
nhiroki
On 2015/06/11 04:22:48, kinuko wrote: > On 2015/06/11 04:19:03, nhiroki wrote: > > A revert ...
4 years, 10 months ago
(2015-06-11 04:33:39 UTC)
#14
Message was sent while issue was closed.
On 2015/06/11 04:22:48, kinuko wrote:
> On 2015/06/11 04:19:03, nhiroki wrote:
> > A revert of this CL (patchset #1 id:20001) has been created in
> > https://codereview.chromium.org/1178753003/ by mailto:nhiroki@chromium.org.
> >
> > The reason for reverting is: I'll remake this CL as per the discussion in
the
> > CL(2)..
>
> It's ok but not sure if you needed to revert? Looks like we could just change
on
> top of it.
No special reason, just to rollback the change. Yes, we were able to make a
change on top of that.
Issue 1166283006: ServiceWorker: Implement ServiceWorkerRegistration.update() (1)
(Closed)
Created 4 years, 10 months ago by nhiroki
Modified 4 years, 10 months ago
Reviewers: falken, tkent
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 0