Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1166223003: [Android] Use the UI thread for VSyncMonitorTest vsync requests (Closed)

Created:
5 years, 6 months ago by jdduke (slow)
Modified:
5 years, 6 months ago
Reviewers:
Sami, mithro-old
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Use the UI thread for VSyncMonitorTest vsync requests VSyncMonitor is not thread-safe, and is not intended to be. When a vsync request is made from a non-UI thread, there is a race where both a synthetic and frame-based callback can fire for the same request. Avoid this by making sure VSyncMonitorTest only requests updates from the UI thread, representative of production code behavior. BUG=498007 Committed: https://crrev.com/aab443b709be482b746ffa47c3a04e69fade3e83 Cr-Commit-Position: refs/heads/master@{#333580}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/android/javatests_shell/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java View 4 chunks +14 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/VSyncMonitor.java View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
jdduke (slow)
skyostil@: PTAL, should have caught this sooner.
5 years, 6 months ago (2015-06-09 01:26:28 UTC) #2
Sami
Thanks for catching this -- lgtm. I guess we can find small comfort in the ...
5 years, 6 months ago (2015-06-09 12:57:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166223003/1
5 years, 6 months ago (2015-06-09 15:15:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/31601)
5 years, 6 months ago (2015-06-09 17:32:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1166223003/20001
5 years, 6 months ago (2015-06-09 21:08:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 21:51:23 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aab443b709be482b746ffa47c3a04e69fade3e83 Cr-Commit-Position: refs/heads/master@{#333580}
5 years, 6 months ago (2015-06-09 21:52:04 UTC) #12
mithro-old
5 years, 6 months ago (2015-06-23 09:14:57 UTC) #13
Message was sent while issue was closed.
Late LGTM. 

Thanks for adding the asserts.

Powered by Google App Engine
This is Rietveld 408576698