content: Handle native GpuMemoryBuffer allocation failures properly.

content: Handle native GpuMemoryBuffer allocation failures properly.

This adds proper handling of cases where the GPU service returns
an invalid handle. This can happen if the GPU process crashed while
there was an allocation request in-flight or if the GPU service is
simply misbehaving.

BUG=486922
Committed: https://crrev.com/fd9f3d27e8569dcc58a18e94891b9443872d362d
Cr-Commit-Position: refs/heads/master@{#333773}

[reveman, 2015-06-10 16:10:05]

reveman@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2015-06-10 17:01:48]

https://codereview.chromium.org/1166213003/diff/1/content/browser/gpu/browser...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1166213003/diff/1/content/browser/gpu/browser...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:343: // The factory
should never return a shared memory backed buffer.
"Should never" implies DCHECK, that it shouldn't happen, and that it's a
programming error if it does. If this is a legitimate error condition that can
happen (as your CL description states) then change this comment.

Rather than "should never", explain the condition for which this can happen and
what it means (e.g. "If the handle isn't valid, that means that the GPU process
crashed or is misbehaving...")

[reveman, 2015-06-10 18:32:09]

ptal

https://codereview.chromium.org/1166213003/diff/1/content/browser/gpu/browser...
File content/browser/gpu/browser_gpu_memory_buffer_manager.cc (right):

https://codereview.chromium.org/1166213003/diff/1/content/browser/gpu/browser...
content/browser/gpu/browser_gpu_memory_buffer_manager.cc:343: // The factory
should never return a shared memory backed buffer.
On 2015/06/10 at 17:01:47, Avi wrote:
> "Should never" implies DCHECK, that it shouldn't happen, and that it's a
programming error if it does. If this is a legitimate error condition that can
happen (as your CL description states) then change this comment.
> 
> Rather than "should never", explain the condition for which this can happen
and what it means (e.g. "If the handle isn't valid, that means that the GPU
process crashed or is misbehaving...")

Good point. Done.

[Avi (use Gerrit), 2015-06-10 18:34:36]

lgtm

👍

[reveman, 2015-06-10 18:41:24]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2015-06-10 18:42:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1166213003/20001

[commit-bot: I haz the power, 2015-06-10 19:24:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-10 19:25:44]

Patchset 2 (id:??) landed as
https://crrev.com/fd9f3d27e8569dcc58a18e94891b9443872d362d
Cr-Commit-Position: refs/heads/master@{#333773}