Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4557)

Unified Diff: chrome/common/extensions/extension.h

Issue 11662013: Move Commands from Extension to CommandsHandler (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.h
diff --git a/chrome/common/extensions/extension.h b/chrome/common/extensions/extension.h
index 0935327e78d484bf96c829d9b1d0a48d4bff85df..b93f31205107a4df2682a63c18b480674589cc61 100644
--- a/chrome/common/extensions/extension.h
+++ b/chrome/common/extensions/extension.h
@@ -21,7 +21,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/synchronization/lock.h"
#include "chrome/common/extensions/api/extension_action/action_info.h"
-#include "chrome/common/extensions/command.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/extension_icon_set.h"
#include "chrome/common/extensions/permissions/api_permission.h"
@@ -682,30 +681,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
const std::vector<InputComponentInfo>& input_components() const {
return input_components_;
}
- // The browser action command that the extension wants to use, which is not
- // necessarily the one it can use, as it might be inactive (see also
- // GetBrowserActionCommand in CommandService).
- const extensions::Command* browser_action_command() const {
- return browser_action_command_.get();
- }
- // The page action command that the extension wants to use, which is not
- // necessarily the one it can use, as it might be inactive (see also
- // GetPageActionCommand in CommandService).
- const extensions::Command* page_action_command() const {
- return page_action_command_.get();
- }
- // The script badge command that the extension wants to use, which is not
- // necessarily the one it can use, as it might be inactive (see also
- // GetScriptBadgeCommand in CommandService).
- const extensions::Command* script_badge_command() const {
- return script_badge_command_.get();
- }
- // The map (of command names to commands) that the extension wants to use,
- // which is not necessarily the one it can use, as they might be inactive
- // (see also GetNamedCommands in CommandService).
- const extensions::CommandMap& named_commands() const {
- return named_commands_;
- }
bool has_background_page() const {
return background_url_.is_valid() || !background_scripts_.empty();
}
@@ -888,7 +863,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool LoadHomepageURL(string16* error);
bool LoadUpdateURL(string16* error);
bool LoadIcons(string16* error);
- bool LoadCommands(string16* error);
bool LoadPlugins(string16* error);
bool LoadNaClModules(string16* error);
bool LoadWebAccessibleResources(string16* error);
@@ -1086,12 +1060,6 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
// Optional list of input components and associated properties.
std::vector<InputComponentInfo> input_components_;
- // Optional list of commands (keyboard shortcuts).
- scoped_ptr<extensions::Command> browser_action_command_;
- scoped_ptr<extensions::Command> page_action_command_;
- scoped_ptr<extensions::Command> script_badge_command_;
- extensions::CommandMap named_commands_;
-
// Optional list of web accessible extension resources.
URLPatternSet web_accessible_resources_;

Powered by Google App Engine
This is Rietveld 408576698