chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm - Issue 11662013: Move Commands from Extension to CommandsHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

Issue 11662013: Move Commands from Extension to CommandsHandler (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/commands/command_service.cc ('K') | « chrome/browser/extensions/api/commands/command_service.cc ('k') | chrome/chrome_common.gypi » ('j') | chrome/common/extensions/api/commands/commands_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

index dedb9bb85bd460999d6c138e009c86565b7fa55c..2d3e9d65d8e46d821352033dcb59875e4ebee0ab 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm

@@ -26,6 +26,7 @@

#include "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h"

#include "chrome/browser/ui/singleton_tabs.h"

#include "chrome/common/chrome_notification_types.h"

+#include "chrome/common/extensions/api/commands/commands_handler.h"

#include "chrome/common/extensions/api/omnibox/omnibox_handler.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/url_constants.h"

@@ -298,7 +299,7 @@ class ExtensionLoadedNotificationObserver

extensions::CommandService* command_service =

extensions::CommandServiceFactory::GetForProfile(browser_->profile());

if (type_ == extension_installed_bubble::kPageAction) {

- if (extension_->page_action_command() &&

+ if (CommandsInfo::GetPageActionCommand(extension_) &&

command_service->GetPageActionCommand(

extension_->id(),

extensions::CommandService::ACTIVE_ONLY,

@@ -315,7 +316,7 @@ class ExtensionLoadedNotificationObserver

extensions::CommandService* command_service =

extensions::CommandServiceFactory::GetForProfile(browser_->profile());

if (type_ == extension_installed_bubble::kBrowserAction) {

- if (extension_->browser_action_command() &&

+ if (CommandsInfo::GetBrowserActionCommand(extension_) &&

command_service->GetBrowserActionCommand(

extension_->id(),

extensions::CommandService::ACTIVE_ONLY,