Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/common/extensions/api/commands/commands_handler.h

Issue 11662013: Move Commands from Extension to CommandsHandler (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_unref_script_badge
Patch Set: Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_
7
8 #include <string>
9
10 #include "base/memory/scoped_ptr.h"
11 #include "chrome/common/extensions/command.h"
12 #include "chrome/common/extensions/extension.h"
13 #include "chrome/common/extensions/manifest_handler.h"
14
15 namespace extensions {
16
17 struct CommandsInfo : public Extension::ManifestData {
18 // Optional list of commands (keyboard shortcuts).
19 // These commands are the commands which the extension wants to use, which are
20 // not necessarily the ones it can use, as it might be inactive (see also
21 // Get*Command[s] in CommandService).
22 scoped_ptr<Command> browser_action_command;
23 scoped_ptr<Command> page_action_command;
24 scoped_ptr<Command> script_badge_command;
25 CommandMap named_commands;
26
27 static const Command* GetBrowserActionCommand(const Extension* extension);
28 static const Command* GetPageActionCommand(const Extension* extension);
29 static const Command* GetScriptBadgeCommand(const Extension* extension);
30 static const CommandMap* GetNamedCommands(const Extension* extension);
31 };
32
33 // Parses the "commands" manifest key.
34 class CommandsHandler : public ManifestHandler {
35 public:
36 CommandsHandler();
37 virtual ~CommandsHandler();
38
39 virtual bool Parse(const base::Value* value,
40 Extension* extension,
41 string16* error) OVERRIDE;
42
43 virtual bool HasNoKey(Extension* extension, string16* error) OVERRIDE;
44
45 private:
46 // If the extension defines a browser action, but no command for it, then
47 // we synthesize a generic one, so the user can configure a shortcut for it.
48 // No keyboard shortcut will be assigned to it, until the user selects one.
49 void MaybeSetBrowserActionDefault(const Extension* extension,
50 CommandsInfo* info);
51 };
52
53 } // namespace extensions
54
55 #endif // CHROME_COMMON_EXTENSIONS_API_COMMANDS_COMMANDS_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698